Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo, getItemUUID involves ID for Item not Vault #64

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix typo, getItemUUID involves ID for Item not Vault #64

merged 1 commit into from
Jul 4, 2022

Conversation

snarlysodboxer
Copy link
Contributor

Discovered this while trying out GetFiles.

@snarlysodboxer snarlysodboxer changed the title Fix typo, getItemUUID gets an Item not Vault Fix typo, getItemUUID involves ID for Item not Vault Jul 2, 2022
@snarlysodboxer snarlysodboxer mentioned this pull request Jul 2, 2022
Closed
edif2008
edif2008 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@edif2008 edif2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making this PR. It was something that slipped through my fingers when writing this function. Really appreciate you finding this bug and fixing it. 🎉

@kpcraig kpcraig merged commit b484a1c into 1Password:main Jul 4, 2022
@snarlysodboxer snarlysodboxer deleted the fix-get-item-uuid branch July 5, 2022 15:59
@github-actions github-actions bot mentioned this pull request Jul 8, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edif2008 edif2008 edif2008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snarlysodboxer @edif2008 @kpcraig