Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYS: Move Lifecycle of a Launch into Handbook #2529

Merged
merged 9 commits into from
Jun 15, 2021

Conversation

dylanirlbeck
Copy link
Contributor

@dylanirlbeck dylanirlbeck commented Jun 15, 2021

Part of 18F/before-you-ship#421

Per Aidan's suggestion, I'm going to break up moving the BYS content into the Handbook into multiple PRs.

This one focuses on the Lifecycle of a Launch page. A short GIF is included below demonstrating the new page running locally.

Questions:

  • Is there a better location for the BYS content on the main Handbook page?
  • Did I consolidate the various tabs on the Lifecycle BYS page properly? I collapsed the content into one Markdown file, but if there is a better structure I'm open to suggestions.

before-you-ship-new-lifecycle

@dylanirlbeck dylanirlbeck changed the title dylanirlbeck/move lifecycle Move Lifecycle of a Launch into Handbook Jun 15, 2021
@dylanirlbeck dylanirlbeck changed the title Move Lifecycle of a Launch into Handbook BYS: Move Lifecycle of a Launch into Handbook Jun 15, 2021
@dylanirlbeck dylanirlbeck requested a review from a team June 15, 2021 15:29
Copy link
Contributor

@adborden adborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start!

Some assumptions/discussion for the future (from our group review):

@adborden adborden enabled auto-merge June 15, 2021 16:39
@adborden adborden merged commit 15f02c0 into master Jun 15, 2021
@adborden adborden deleted the dylanirlbeck/move-lifecycle branch June 15, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants