This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Updates 0x API parameters documentation for RFQ #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
steveklebanoff
suggested changes
Jul 27, 2020
| @@ -171,6 +174,9 @@ When both are provided, `sellAmount` takes precedence over `buyAmount`. | |||
| | `gasPrice` | (Optional, defaults to ethgasstation "fast") The target gas price (in wei) for the swap transaction. If the price is too low to achieve the quote, an error will be returned. | | |||
| | `takerAddress` | (Optional) The address which will fill the quote. When provided the gas will be estimated and returned. An eth_call will also be performed. If this fails a Revert Error will be returned in the response. | | |||
| | `excludedSources` | (Optional) Liquidity sources (`Eth2Dai`, `Uniswap`, `Kyber`, `0x`, `LiquidityProvider` etc) that will not be included in the provided quote. Ex: `excludedSources=Uniswap,Kyber,Eth2Dai`. See [here](https://github.com/0xProject/0x-monorepo/blob/development/packages/asset-swapper/src/utils/market_operation_utils/types.ts#L27) for a full list of sources | | |||
| | `includedSources` | (Optional) For now only supports `RFQT`, which should be used when the integrator only wants RFQT liquidity without any other DEX orders. Requires a particular agreement with the 0x integrations team. This parameter cannot be combined with `includedSources`. | | |||
There was a problem hiding this comment.
IMHO I think we should leave these RFQT params out for now until we get the complete RFQT documentation out
feuGeneA
added a commit
that referenced
this pull request
Aug 13, 2020
Changes ported from #318 at the request of @PirosB3 in comment #322 (comment)
|
Hi Daniel! Would you mind closing out this PR or at least removing me from the Reviewers? I'd love to get it off my list. I hope you've been well! Thank you! |
|
Hi @PirosB3 ! Would you mind closing out this PR or at least removing me from the Reviewers? I'd love to get it off my list of pending review requests. I hope you've been well! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.