This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: Add Balancer as a source #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dgeSource and gas/fee schedules
moodlezoup
force-pushed
the
feat/balancer
branch
from
6b6ce56 to
6d15016
Compare
xianny
reviewed
Jul 10, 2020
| [ERC20BridgeSource.Kyber]: () => 8e5, | ||
| [ERC20BridgeSource.Curve]: fillData => { | ||
| switch ((fillData as CurveFillData).poolAddress.toLowerCase()) { | ||
| case '0xa2b47e3d5c44877cca798226b7b8118f9bfb7a56': |
There was a problem hiding this comment.
can we make these addresses constants somewhere? Maybe even just an obj in this file.
CurvePoolAddresses = {
UsdcDai: '...',
}
10 tasks
moodlezoup
force-pushed
the
feat/balancer
branch
from
0b54a4b to
c279afc
Compare
moodlezoup
force-pushed
the
feat/balancer
branch
from
c279afc to
3202619
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
@0x/asset-swapperand@0x/contract-addressesto add Balancer support.Reflects updates to the
ERC20BridgeSourceenum and the new gas/fee schedule interface.DO NOT MERGE until
@0x/asset-swapperand@0x/contract-addressesare updated to non-gitpkg versions, or at least gitpkg publishes that are on the monorepo development branchDescription
Testing Instructions
Checklist
[WIP]if necessary.