stark: additional documentation for generate_fri_parameters #975
Conversation
| dropw | ||
| drop | ||
| drop | ||
| drop |
There was a problem hiding this comment.
These 2 new drops are clearing the stack of the two 0s loaded together with lde size. The idea is that the procedure should leave the stack in the state documented in Output.
However, this is not really necessary, because this is called by the verify procedure, and the stack is "empty" at that point.
I'm keeping it because it makes refactoring code easier. Let me know if anyone disagrees.
There was a problem hiding this comment.
Totally agree, it should conform to the expected output stated in the header. Thank you for catching that!
hackaugusto
force-pushed
the
hacka-additional-documentation-for-generate_fri_parameters
branch
from
7cbd4ca to
3de6fd9
Compare
hackaugusto
force-pushed
the
hacka-additional-documentation-for-generate_fri_parameters
branch
from
3de6fd9 to
99337cc
Compare
|
|
||
| # Compute trace_domain_generator | ||
| # Compute trace generator `trace_g` = `lde_g^blowup_factor` | ||
| repeat.3 |
There was a problem hiding this comment.
This is an instance that would benefit from #970
There was a problem hiding this comment.
I think this as well as compute_lde_generator should be deprecated with the work you have done on the AirScript side, right?
There was a problem hiding this comment.
I suppose you're talking about the binary search? I closed that PR since the code was complicated 0xPolygonMiden/air-script#320 (comment) .
Instead I'm going to save this value to memory and the AirScript codegen will load from the memory.
|
|
||
| # Compute trace_domain_generator | ||
| # Compute trace generator `trace_g` = `lde_g^blowup_factor` | ||
| repeat.3 |
There was a problem hiding this comment.
I think this as well as compute_lde_generator should be deprecated with the work you have done on the AirScript side, right?
| dropw | ||
| drop | ||
| drop | ||
| drop |
There was a problem hiding this comment.
Totally agree, it should conform to the expected output stated in the header. Thank you for catching that!
hackaugusto
deleted the
hacka-additional-documentation-for-generate_fri_parameters
branch
Describe your changes
As the PR titles says. I'm going to changed #960 to compute the constant and save it here, but I needed a bit more detail about the stack state to do that.
Opening as a separated PR for an easier review.
Checklist before requesting a review
nextaccording to naming convention.