-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove 8 bit portion of the range checker #906
Conversation
6d957c2
to
b97401f
Compare
b97401f
to
449812b
Compare
If I'm reading test runtimes correctly, it seems that they increased by 30% - 40% - is this right? If so, maybe it's not too bad. If there are some simple ways to reduce them, we can do that now - but if not, we can leave that for future PRs. |
On M1 with 8 cores, it goes from ~47 seconds to ~500 seconds for integration tests. |
Is this via |
Ah, that was using |
|
|
@bobbinth Sorry, I ran it on the wrong branch earlier. It actually goes from ~4 to ~60 seconds. |
Hmmm - could you double-check? A 15x increase seems rather high - I would have expected an 8x increase in the worst possible case. |
Yeah, makes sense. The runtime number seems correct (checked 5 times). Let me look into it and get back. |
Closing this PR since this design increases the minimum trace length to |
Describe your changes
Addressing #395. Simplifies the range checker design by removing the 8-bit segment of the range checker table. This however increases the minimum length of the trace since we can no longer use the 8-bit table after this change to allow jumps of$2^8$ and instead can only allow jumps of 8 because that requires a constraint of degree 9. The following constraint ensures consistency of the range checker table.
Checklist before requesting a review
next
according to naming convention.