Merkle mountain range partial #86
Conversation
hackaugusto
force-pushed
the
hacka-merkle-mountain-range-partial
branch
from
0dd24c2 to
8b87b08
Compare
src/merkle/mmr/partial.rs
Outdated
| /// A partial view of the MMR. | ||
| /// | ||
| /// Data structure used to maintain the proof of a single value up-to-date. Only the data relevant | ||
| /// to `value` is stored, meaning the path from the leaf to the root, and the peaks in the MMR that |
There was a problem hiding this comment.
When we say path from the leaf to the root, can we specify in the docs if we refer to a peak or absolute root (i.e. the root of the peaks)?
There was a problem hiding this comment.
Updated it to path from the leaf to the peak.
There was a problem hiding this comment.
And to clarify, this implementation can not have the hash(peaks). That would imply the partial view would need to be updated with every message.
edit: well ... we could change it to have a valid but not necessarily up-to-date value. This isn't implemented ATM. Maybe I should update @bobbinth , any opinions?
| /// Note: It is the caller's responsability to call update with the correct sibling node, | ||
| /// otherwise the updated root will be incorrect. | ||
| pub fn update(&mut self, right_sibling: Word) { |
There was a problem hiding this comment.
Should this be exposed as public? It might lead to an inconsistent state of the tree, so I think we should either leave it in private scope, or suffix it with _unchecked
There was a problem hiding this comment.
Yes, the purpose of this structure is to have a partial view of the MMR that can be sporadically updated, this method can not be private.
Is _unchecked the best option? This shouldn't panic
hackaugusto
force-pushed
the
hacka-merkle-mountain-range-partial
branch
from
8b87b08 to
21fd481
Compare
hackaugusto
force-pushed
the
hacka-merkle-mountain-range-partial
branch
from
21fd481 to
b305c7e
Compare
|
@bobbinth this PR has a few conflicts now, let me know if I should rebase it, I don't know if we still want this. |
|
We'll probably come back to this later - so, don't close it yet. As for rebasing, if it is not too much effort then, yes - I'd keep it up to date. |
|
superseded by #195 |
Describe your changes
This adds the MmrPartial structure, useful to keep track of a single entry in the MMR and have infrequent updates.
Checklist before requesting a review
nextaccording to naming convention.