-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: support adding existing structures #139
store: support adding existing structures #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left one comment inline. One other thing: I was thinking that we'd remove most with_*
and add_*
methods after this. Is there a reason to keep them around?
edit: btw, the merkle path doesn't iterate over the inner nodes (it doesn't have them), it actually needs to compute instead. I have a PR for that already #122 , once we get that it should be easy to transform it to a edit2: forgot to mention, we can probably remove the methods for the MMR / SMT, let me know if I should remove these. |
57a9583
to
8161477
Compare
Let's remove all methods that we can and we'll remove the remaining ones later. |
9761115
to
59595a2
Compare
Describe your changes
fixes #136
implemented the extend trait for the merkle store, consume an iterator over inner nodes. this can be used to add existing structures into the store.
Checklist before requesting a review
next
according to naming convention.