-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update contracts #97
Conversation
@@ -21,12 +21,22 @@ env: | |||
POLYGON_MAIN_NETWORK_FLAG: "0b0001_0001" | |||
POLYGON_MAIN_CHAIN_ID: "137" | |||
|
|||
PRIVADO_MAIN_CONTRACT_ADDRESS: "0x975556428F077dB5877Ea2474D783D6C69233742" | |||
POLYGON_ZKVM_CONTRACT_ADDRESS: "0x3C9acB2205Aa72A05F6D77d708b5Cf85FCa3a896" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POLYGON_ZKEVM not POLYGON_ZKVM
and better POLYGON_ZKEVM_MAIN_...
POLYGON_ZKVM_NETWORK_FLAG: "0b0001_0100" | ||
POLYGON_ZKVM_CHAIN_ID: "1101" | ||
|
||
POLYGON_CARDONA_CONTRACT_ADDRESS: "0x3C9acB2205Aa72A05F6D77d708b5Cf85FCa3a896" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better rename to POLYGON_ZKEVM_CARDONA.
Btw, where are these env vars are used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap, I forgot to add to yaml file
No description provided.