fix(jsonQuery): allowedIssuers with null & '*' (#175)

0xPolygonID · Feb 6, 2024 · 2adee59 · 2adee59
1 parent 6965be6
commit 2adee59
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/storage/filters/jsonQuery.ts b/src/storage/filters/jsonQuery.ts
@@ -227,8 +227,8 @@ export const StandardJSONCredentialsQueryFilter = (query: ProofQuery): FilterQue
       case 'claimId':
         return acc.concat(new FilterQuery('id', comparatorOptions.$eq, queryValue));
       case 'allowedIssuers': {
-        const [first] = queryValue || [];
-        if (first && first === '*') {
+        const queryValueParam = queryValue || ['*'];
+        if (queryValueParam.includes('*')) {
           return acc;
         }
         return acc.concat(new FilterQuery('issuer', comparatorOptions.$in, queryValue));

diff --git a/tests/credentials/credential-wallet.test.ts b/tests/credentials/credential-wallet.test.ts
@@ -379,6 +379,18 @@ const credentialFlow = async (storage: IDataStorage) => {
         }
       },
       expected: []
+    },
+    {
+      query: {
+        allowedIssuers: undefined,
+      },
+      expected: [cred1, cred2, cred3, cred4]
+    },
+    {
+      query: {
+        allowedIssuers: ['issuer1', '*'],
+      },
+      expected: [cred1, cred2, cred3, cred4]
     }
   ];