chore: add proofs to create claim endpoint #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBrezhniev
reviewed
Jun 26, 2024
internal/api/server.go
Outdated
| @@ -151,6 +151,9 @@ func (s *Server) CreateIdentity(ctx context.Context, request CreateIdentityReque | |||
|
|
|||
| // CreateClaim is claim creation controller | |||
| func (s *Server) CreateClaim(ctx context.Context, request CreateClaimRequestObject) (CreateClaimResponseObject, error) { | |||
| const BJJSignatureProof2021 = "BJJSignatureProof2021" | |||
There was a problem hiding this comment.
Can you use constants from here: https://github.com/iden3/go-schema-processor/blob/684a4b617a0eaf8452d4f3a65a4a6704ad53cbdf/verifiable/constants.go#L40
There was a problem hiding this comment.
Or the ones you defined in internal/api/api.gen.go
OBrezhniev
approved these changes
Jun 26, 2024
martinsaporiti
deleted the
PID-2261-update-create-claim-endpoint-to-support-proof-s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
With this feature the user can specify the type of proof for the claim