feat: allow isolation of OP sovereign deployment #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ji Hwan <jkim@polygon.technology>
praetoriansentry
previously approved these changes
Feb 24, 2025
There was a problem hiding this comment.
I think i'm good with this. Two thoughts:
- I think
deploy_optimism_sovereign_isolatedflag should probably be added to your nightly op stack configuration - We should think if there is any situation where we MUST have
deploy_optimism_sovereign_isolatedfalse whendeploy_optimism_rollupis true. If there is nothing that we can think of, we could also remove the flag and just make this the behavior. The idea being that you could run a separate process (maybe) to add an op-stack to an enclave that already has a cdk-erigon node running
jhkimqd
force-pushed
the
jihwan/isolate-op-deployment
branch
from
c0adae5 to
8da1c89
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/isolate-op-deployment
branch
from
8da1c89 to
2daf97e
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
|
praetoriansentry
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new parameter "deploy_optimism_sovereign_isolated": False,. If set to True together with deploy_optimism_rollup parameterchanges the behavior of deploy_optimism_rollup parameter. If set to True, it will only deploy L1 + Agglayer + Aggkit + Sovereign Rollup without deploying the CDK Erigon stack.Updated:
This PR changes the behavior of
deploy_optimism_rollupparameter. If set toTrue, it will only deploy L1 + Agglayer + Aggkit + Sovereign Rollup without deploying the CDK Erigon stack.