-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate op-succinct #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
vcastellm
reviewed
Feb 18, 2025
…ntegration Signed-off-by: Ji Hwan <jkim@polygon.technology>
…ntegration Signed-off-by: Ji Hwan <jkim@polygon.technology>
1cd73c3
to
c6cf68b
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
c6cf68b
to
711c97f
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
0ed32b1
to
23377ea
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
23377ea
to
35665e8
Compare
d0e38b9
to
b2af755
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
b2af755
to
f90e59d
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
praetoriansentry
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes but overall looks good!
Signed-off-by: Ji Hwan <jkim@polygon.technology>
28c5fe7
to
7572b46
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
5f3b607
to
0515def
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
praetoriansentry
previously approved these changes
Feb 26, 2025
praetoriansentry
previously approved these changes
Feb 26, 2025
6d659b5
to
bf98a0d
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
bf98a0d
to
5dd3379
Compare
|
praetoriansentry
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates OP-Succinct into Kurtosis CDK.
It relies on custom built docker images to host the below images:
On v1.2.2 of OP-Succinct.
OP-Succinct has a mock-verifier option, but the OP-Succinct stack requires a valid
agglayer_prover_sp1_key
to work and submit proofs to L1.Note how there is no deployment suffix in the op-succinct components - this is because the current implementation of OP-Succinct components rely on having fixed names (
op-succinct-proposer
andop-succinct-server
) and is not easily configurable at the time of this PR.Testing
Refer to the the configuration in the docs and simply run
kurtosis run --enclave=cdk --args-file=./.github/tests/chains/op-succinct.yml .
Monitor the L2 finalized block number incrementing using
kurtosis service logs cdk op-succinct-proposer -f