Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate op-succinct #486

Merged
merged 26 commits into from
Feb 26, 2025
Merged

feat: integrate op-succinct #486

merged 26 commits into from
Feb 26, 2025

Conversation

jhkimqd
Copy link
Collaborator

@jhkimqd jhkimqd commented Feb 17, 2025

Description

This PR integrates OP-Succinct into Kurtosis CDK.

It relies on custom built docker images to host the below images:

  • op-succinct-server
  • op-succinct-proposer
  • op-succinct-contract-deployer

On v1.2.2 of OP-Succinct.

OP-Succinct has a mock-verifier option, but the OP-Succinct stack requires a valid agglayer_prover_sp1_key to work and submit proofs to L1.

Note how there is no deployment suffix in the op-succinct components - this is because the current implementation of OP-Succinct components rely on having fixed names (op-succinct-proposer and op-succinct-server) and is not easily configurable at the time of this PR.

image

Testing

Refer to the the configuration in the docs and simply run kurtosis run --enclave=cdk --args-file=./.github/tests/chains/op-succinct.yml .

Monitor the L2 finalized block number incrementing using kurtosis service logs cdk op-succinct-proposer -f

image

Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd marked this pull request as draft February 17, 2025 15:40
@jhkimqd jhkimqd changed the title feat: integrate op-succint [DO-NOT-MERGE] feat: integrate op-succint Feb 17, 2025
@jhkimqd jhkimqd changed the title [DO-NOT-MERGE] feat: integrate op-succint [DO-NOT-MERGE] feat: integrate op-succinct Feb 18, 2025
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from 1cd73c3 to c6cf68b Compare February 20, 2025 10:10
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from c6cf68b to 711c97f Compare February 20, 2025 10:14
jhkimqd and others added 4 commits February 20, 2025 19:15
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from 0ed32b1 to 23377ea Compare February 21, 2025 06:49
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from 23377ea to 35665e8 Compare February 21, 2025 06:55
@jhkimqd jhkimqd marked this pull request as ready for review February 21, 2025 07:11
@jhkimqd jhkimqd changed the title [DO-NOT-MERGE] feat: integrate op-succinct feat: integrate op-succinct Feb 21, 2025
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch 2 times, most recently from d0e38b9 to b2af755 Compare February 21, 2025 14:08
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from b2af755 to f90e59d Compare February 21, 2025 14:10
Copy link
Member

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes but overall looks good!

Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from 28c5fe7 to 7572b46 Compare February 25, 2025 00:50
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from 5f3b607 to 0515def Compare February 25, 2025 04:59
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd enabled auto-merge February 25, 2025 15:24
Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd force-pushed the jihwan/op-succinct-integration branch from bf98a0d to 5dd3379 Compare February 26, 2025 01:34
@jhkimqd jhkimqd merged commit b74c90c into main Feb 26, 2025
25 checks passed
@jhkimqd jhkimqd deleted the jihwan/op-succinct-integration branch February 26, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants