-
-
Notifications
You must be signed in to change notification settings - Fork 234
Add Timescale DB with Hypertable and Retention support #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test it, but it looks good so far for me 👍 . We do have some e2e tests with testcontainers (real database as docker container) for query log. Maybe you could create e2e test for timescale DB? If not, I can also do it.
2aa3f67
to
a05f4db
Compare
I added some e2e tests. Is this ok? |
5f5d410
to
300c385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for your work!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 93.88% 93.92% +0.04%
==========================================
Files 78 79 +1
Lines 6361 5056 -1305
==========================================
- Hits 5972 4749 -1223
+ Misses 300 217 -83
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
Please fix the linter error to make build green again, then we can merge |
300c385
to
d9b6a5b
Compare
The linter error is fixed. I'll try to increase coverage later :) |
Should we merge it now or do you want to add some tests with this PR? |
You can merge now. I'll open another PR for the tests. Thanks. |
With this pull I want to add support of Timescale DB to blocky.
It uses the postgres connection (
queryLog.target=postgres://...
) of GORM to write data, but uses hypertabels to store time-series data and uses Timescales-native retention withqueryLog.type=timescale
.