-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli-utils): add experimental support for .vue
SFC files
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7644358 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cf07d81
to
4b5481b
Compare
3 tasks
JoviDeCroock
commented
Apr 19, 2024
.vue
files.vue
files
JoviDeCroock
commented
Apr 19, 2024
JoviDeCroock
commented
Apr 19, 2024
JoviDeCroock
commented
Apr 19, 2024
kitten
reviewed
Apr 19, 2024
JoviDeCroock
commented
Apr 19, 2024
JoviDeCroock
commented
Apr 19, 2024
15d820c
to
9981a6e
Compare
c87874d
to
eb706cc
Compare
kitten
approved these changes
Apr 19, 2024
.vue
files.vue
SFC files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #210
Resolves #231
Summary
This PR adds support for parsing
.vue
files, it will use the Vue compiler to create an intermediary representation ints-morph
.I added this initially only to
check
so we can align on the solution and I can expand it into multiple other after.Some potential improvements
moduleResolutionHost
to route.vue
files to.vue.tada.ts
or something similar. Now we are forced to name them.vue.ts
files so that TS picks them up automatically