Skip to content

Commit

Permalink
[chore] prettier format
Browse files Browse the repository at this point in the history
  • Loading branch information
jchip committed Feb 9, 2018
1 parent 689af78 commit 3a2cd39
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 28 deletions.
8 changes: 2 additions & 6 deletions packages/electrode-react-webapp/lib/default-handlers.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,8 @@ module.exports = function setup(options) {
: Array.prototype.concat(data.cssChunk);

const cssLink = css.reduce((acc, file) => {
acc += `<link rel="stylesheet" href="${
WEBPACK_DEV
? file
: prodBundleBase + file.name
}" />`;
return acc;
file = WEBPACK_DEV ? file : prodBundleBase + file.name;
return `${acc}<link rel="stylesheet" href="${file}" />`;
}, "");

const htmlScripts = htmlifyScripts(
Expand Down
24 changes: 10 additions & 14 deletions packages/electrode-react-webapp/lib/react-webapp.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,23 +107,18 @@ function makeRouteHandler(routeOptions, userContent) {

let devCSSBundle;
if (chunkNames.css) {
const cssChunks = Array.isArray(chunkNames.css)
? chunkNames.css
: [ chunkNames.css ];
devCSSBundle = _.map(
cssChunks,
(chunkName) => `${devBundleBase}${chunkName}.style.css`
);
} else devCSSBundle = [`${devBundleBase}style.css`];
const cssChunks = Array.isArray(chunkNames.css) ? chunkNames.css : [chunkNames.css];
devCSSBundle = _.map(cssChunks, chunkName => `${devBundleBase}${chunkName}.style.css`);
} else {
devCSSBundle = [`${devBundleBase}style.css`];
}

const devJSBundle = chunkNames.js
? `${devBundleBase}${chunkNames.js}.bundle.dev.js`
: `${devBundleBase}bundle.dev.js`;
const jsChunk = _.find(assets.js, asset => _.includes(asset.chunkNames, chunkNames.js));
const cssChunk = _.filter(assets.css,
asset => _.some(asset.chunkNames,
assetChunkName => _.includes(chunkNames.css, assetChunkName)
)
const cssChunk = _.filter(assets.css, asset =>
_.some(asset.chunkNames, assetChunkName => _.includes(chunkNames.css, assetChunkName))
);
const scriptNonce = cspScriptNonce ? ` nonce="${cspScriptNonce}"` : "";
const styleNonce = cspStyleNonce ? ` nonce="${cspStyleNonce}"` : "";
Expand Down Expand Up @@ -207,8 +202,9 @@ const setupOptions = options => {
const pluginOptions = _.defaultsDeep({}, options, pluginOptionsDefaults);
const chunkSelector = resolveChunkSelector(pluginOptions);
const devProtocol = process.env.WEBPACK_DEV_HTTPS ? "https://" : "http://";
const devBundleBase = `${devProtocol}${pluginOptions.devServer.host}:${pluginOptions.devServer
.port}/js/`;
const devBundleBase = `${devProtocol}${pluginOptions.devServer.host}:${
pluginOptions.devServer.port
}/js/`;
const statsPath = getStatsPath(pluginOptions.stats, pluginOptions.buildArtifacts);

const assets = loadAssetsFromStats(statsPath);
Expand Down
5 changes: 1 addition & 4 deletions packages/electrode-react-webapp/test/data/chunk-selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@ const DEFAULT_BUNDLE = {
js: "home"
};
const MULTI_BUNDLE = {
css: [
"foo",
"bar"
],
css: ["foo", "bar"],
js: "home"
};

Expand Down
8 changes: 4 additions & 4 deletions packages/electrode-react-webapp/test/spec/hapi.index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,9 @@ describe("hapi electrode-react-webapp", () => {
})
.then(res => {
expect(res.statusCode).to.equal(200);
expect(res.result).to.contain("http://127.0.0.1:2992/js/foo.style.css");
expect(res.result).to.contain("http://127.0.0.1:2992/js/bar.style.css");
expect(res.result).to.contain("http://127.0.0.1:2992/js/home.bundle.dev.js");
expect(res.result).to.contain("http://127.0.0.1:2992/js/foo.style.css");
expect(res.result).to.contain("http://127.0.0.1:2992/js/bar.style.css");
expect(res.result).to.contain("http://127.0.0.1:2992/js/home.bundle.dev.js");
stopServer(server);
})
.catch(err => {
Expand Down Expand Up @@ -872,7 +872,7 @@ describe("hapi electrode-react-webapp", () => {
})
.then(res => {
expect(res.statusCode).to.equal(404);
expect(res.result).to.contain("<div class=\"js-content\">html content</div>");
expect(res.result).to.contain('<div class="js-content">html content</div>');
stopServer(server);
})
.catch(err => {
Expand Down

0 comments on commit 3a2cd39

Please sign in to comment.