inbox: Implement workable dark theme #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
|
Thanks! This looks good. There's a merge conflict with #857 which I just merged — so please go ahead and merge after resolving that. |
chrisbobbe
force-pushed
the
pr-inbox-dark-theme
branch
from
aee29f1 to
3a7a08e
Compare
NFC because we don't support dark theme yet.
This completes a workable dark-theme implementation for the inbox screen. It's likely that some colors will be tweaked to follow designs that haven't been made yet. As noted in TODOs in each color that's placed here: - Some of the UI elements are colored with actual design variables from the new Figma that's marked ready for dev. But that Figma doesn't yet have those same UI elements, so it's unclear if it's the right choice of variable. - Some dark-theme colors were made up by me just now. NFC because none of the light-theme colors are changed, and we don't support dark theme yet.
chrisbobbe
force-pushed
the
pr-inbox-dark-theme
branch
from
3a7a08e to
c6abaf9
Compare
|
Thanks for the review! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that most of these colors are provisional because there isn't a source for them in web or the Figma designs we have so far. I've noted these with TODOs in the code, to double-check with Vlad.
Stacked atop #854, which makes a (barely discernible) user-facing color change in light theme; see screenshots there.
Otherwise, light theme is unchanged. Here's a side-by-side for light and dark themes at the tip of this PR.
Related: #95