Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: Fix excess fetching on scrolling past code blocks #508

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Feb 7, 2024

Fixes: #507

The main method here was accurately named when first introduced
in 5abeb88.  But then in bccaead its job broadened, so it
should get a more generic name.

(This was basically a mismerge, I think.  The latter commit was
originally written first, so the original draft would have had
its own set of methods, and when I rebased atop the former commit
I apparently didn't do the refactoring that was then called for.)
@chrisbobbe chrisbobbe merged commit 6ffcc45 into zulip:main Feb 8, 2024
1 check passed
@chrisbobbe
Copy link
Collaborator

Thanks! Merged.

@gnprice gnprice deleted the pr-scroll-notif branch February 8, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious fetch-older request when scrolling past a code block
2 participants