Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show save option for framed PDFs when parent page has translator #288

Open
dstillman opened this issue Aug 7, 2019 · 1 comment
Open

Comments

@dstillman
Copy link
Member

dstillman commented Aug 7, 2019

In #155 we started showing a PDF icon if there's a PDF in a frame and no translator on the parent page.

Without #152, though, it's not possible to save the framed PDF itself if the parent page has a translator, unless you're using Firefox and can use This Frame -> Show Only This Frame. Even with #152, ideally we would just offer "(PDF)" as an option in the save button context menu when there's a PDF frame, regardless of whether there's a translator on the parent page.

(This will be even more important once we have a generic translator running on all pages, though we'll probably want to try to determine when there's a wrapper page with no content and still show the PDF icon in those cases.)

@adomasven
Copy link
Member

This is probably an extreme edge case, but we'll need to work something out if there's multiple frames, probably just rely on #152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants