Fix custom type name for reuse #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwonko
reviewed
Mar 1, 2019
| return nil | ||
| } | ||
|
|
||
| var strintStr StrintD |
There was a problem hiding this comment.
this has to be a string or we end up in an infinite loop.
This was referenced Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Fix Custom data type
PrecisionTtoStrintD. (comes from:String & Int data type for datadog)Custom data type
PrecisionTcan reuse for other params. (like width/heght in #195 ).But reuse in other param, the data name would confuse users.