[WIP]Feature/fix width/height data type #195
Conversation
teraken0509
force-pushed
the
feature/fix-width-data-type
branch
from
69ed203 to
1b256b3
Compare
integration/screenboards_test.go
Outdated
| Height: datadog.Int(600), | ||
| Width: datadog.Int(800), | ||
| Height: datadog.JsonNumber("600"), | ||
| Width: datadog.JsonNumber("800"), |
There was a problem hiding this comment.
Similar to #194, this code will fail downstream during marshalling, right before sending the payload to the client. Try setting Width: datadog.JsonNumber("100%"), here to expose the issue.
There was a problem hiding this comment.
Thanks for review.
Fixed it.
teraken0509
changed the title
teraken0509
force-pushed
the
feature/fix-width-data-type
branch
from
12ec6cf to
bc494cb
Compare
teraken0509
changed the title
| "fmt" | ||
| ) | ||
|
|
||
| // WidthS ... | ||
| type WidthS string |
There was a problem hiding this comment.
#194 isn't merged yet.
And using PrecisionT as width or height several difficulty for user to consider its meaning.
If used same struct in whole this package, i think shoud be better assign general name.
There was a problem hiding this comment.
Can you comment on #194 asking for a more generic name? I believe this will be merged more easily if you make it rely on existing code
There was a problem hiding this comment.
#194 was merged, you could change the name of the custom type in this PR
There was a problem hiding this comment.
i split PR at #198 .
After merge, i rebase this pr.
teraken0509
force-pushed
the
feature/fix-width-data-type
branch
from
bc494cb to
cdd39ee
Compare
teraken0509
changed the title
Fixes https://github.com/terraform-providers/terraform-provider-datadog/pull/118
widthparam takes int & string like100%heightparam also can be int or string