Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality detection when aspect ratio != 16/9 #626

Closed
zoriya opened this issue Sep 30, 2024 · 0 comments · Fixed by #755
Closed

Quality detection when aspect ratio != 16/9 #626

zoriya opened this issue Sep 30, 2024 · 0 comments · Fixed by #755
Labels
bug Something isn't working transcoder
Milestone
v4.7.1

Comments

@zoriya
Copy link
Owner

zoriya commented Sep 30, 2024

Kyoo's version

No response

What happened?

We detect the video's quality using video height, this yield one quality lower than expected when aspect ratio is not 16/9.
This is only applicable for video files that can't be natively played.
@zoriya zoriya added the bug Something isn't working label Sep 30, 2024
@zoriya zoriya added this to the v4.8.0 milestone Sep 30, 2024
@zoriya zoriya modified the milestones: v4.8.0, v4.7.1 Jan 2, 2025
@zoriya zoriya mentioned this issue Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working transcoder
Projects
None yet
Milestone
v4.7.1
Development

Successfully merging a pull request may close this issue.

Handle non resize transcode zoriya/Kyoo
1 participant
@zoriya