-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Shortcut Task Export to Multiple Answers #2228
Comments
Good point, seems like that line you pointed out should do away with the whole distinction of singlular label vs. multiple labels. How about just getting all labels, and if there's only one label, unwrap the array and return the only element rather than an array? Might be nicer than yet another special condition in there. |
Take note, I don't have time to work on this. Most of us have clocked out for the week, if it's urgent, you might need to remind people on monday. |
Doesn't need to be done today (PR is still up on the frontend fix), but would be nice to have it done Monday. |
That'd work, @marten, but the "multiple" type can have a single answer as well so the type still needs to be checked. That is, unless we can return just a type-consistent, single-element array in all cases, which would make more sense from a data processing standpoint. I'll take a better look at this tomorrow when I'm back but it's not the greatest time to need something turned around overnight. This won't impact the project outside of exports, though. |
In anticipation for the Stellar Watch launch on Wednesday (3/15) the Shortcut task needs to allow the possibility of multiple shortcut answers. Currently, only one shortcut answer is allowed. The logic has been hooked up on the front-end with this PR.
I believe the only backend change needed is with the exporter? If so, I believe this is the line that needs to be addressed so the
shortcut
type behaves more likemultiple
by receiving an array of index values. However, I could be missing something.The text was updated successfully, but these errors were encountered: