Update dependencies (mio 0.6, slab 0.3) #61
Conversation
|
Thanks |
|
Hmm, I saw |
|
Thanks for merging! |
|
@deniskolodin The real socket tests (those in the "tests" folder) fail with EAGAIN now though - I believe your PR might not have been a perfect update. 😅 |
|
@lhecker Wow! Why all tests hadn't ran? I thought |
|
If mio deprecated all its IO wrappers to I saw |
| return Err(make_timeout()); | ||
| } | ||
| } | ||
| Err(err) => { |
There was a problem hiding this comment.
You have to handle err.kind() == ErrorKind::WouldBlock!!!
| return Err(make_timeout()); | ||
| } | ||
| } | ||
| Err(err) => { |
There was a problem hiding this comment.
The same as above, you have to handle WouldBlock
|
@deniskolodin I believe Nice catch @zonyitoo! 😂 |
|
I would revert this PR. Please @deniskolodin handles |
|
Ok, I'll make it right. |
|
@zonyitoo @deniskolodin I fixed it real quick just now. 🙂 |
|
Awesome! |
|
@lhecker Thanks a lot! 😍 But what about |
|
PR #64 adds these flags |
This PR updates dependencies of this crate.
I've done it to prepare the crate for some experiments with #56
All changes keeps backward compatibility, but some implementations changed. I've changed
acceptmethods, becausemiohas changes with API and most of structs used by this crate had deprecated.Let's consider this PR as keep crate alive changes and as first step towards the new mio's API.