add fully qualified versions of wizard path helpers #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-garland
force-pushed
the
implement-next-url-and-previous-url
branch
from
2c6ad62 to
efc88e0
Compare
|
@schneems Any thoughts or questions on this PR? |
1 similar comment
|
@schneems Any thoughts or questions on this PR? |
|
Seems good. Thanks! |
|
This is released in 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
*_urlversions ofwizard_path,next_wizard_path, andprevious_wizard_path.There are a few reasons we would like to see this in the gem:
First, it brings the wizard route helpers into alignment with Rails convention which offers both
*_pathand*_urlhelpers.Second, it also allows us to honor the HTTP spec which says that all redirects should be fully qualified.
Finally, our wizards involve a user signing in or creating an account and we use a Single Sign On solution for that which requires redirecting out to a different app and then getting redirected back. We need to pass a fully qualified url to the SSO app so that it can return the user to us correctly. We have created this in our own controller so we aren't blocked but it would be nice if the gem provided them.