Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 422 (unprocessable entity) when form submissions fails #278

Closed
marckohlbrugge opened this issue Jun 17, 2021 · 1 comment · Fixed by #294
Closed

Return 422 (unprocessable entity) when form submissions fails #278

marckohlbrugge opened this issue Jun 17, 2021 · 1 comment · Fixed by #294

Comments

@marckohlbrugge
Copy link

marckohlbrugge commented Jun 17, 2021 •
edited
Loading

Hotwire Turbo (formerly known as Turbolinks) requires a failed POST request to return a 422 response (unprocessable entity). Wicked currently returns a 200 (ok) response which makes it incompatible with Turbo.

In the past a PR ( #267 ) was created to change the status to unprocessable entity but this was rejected in order to stick to Rails' own defaults.

These defaults in Rails have now changed to also use 422 for failed POST requests. So I'd like to request Wicked to be updated to do the same.

The existing PR seems like a good solution.
@marckohlbrugge marckohlbrugge mentioned this issue Jun 17, 2021
Closed
@deepakmahakale
Copy link
Member

Sounds good
But we may need to rebase the PR.

@deepakmahakale deepakmahakale mentioned this issue Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return 422 - :unprocessable_entity when form submissions fails zombocom/wicked
2 participants
@marckohlbrugge @deepakmahakale