Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala-js encoding not consistent with jvm encoding #746

Closed
ThijsBroersen opened this issue Oct 1, 2022 · 2 comments
Closed

Scala-js encoding not consistent with jvm encoding #746

ThijsBroersen opened this issue Oct 1, 2022 · 2 comments

Comments

@ThijsBroersen
Copy link
Contributor

I encountered a difference between encoding a double with zio-json.

  • jvm encodes a round double including the 1 decimal, e.g1.0 to 1.0
  • scala-js encodes a round double to an int-like number, e.g 1.0 to 1
@ThijsBroersen ThijsBroersen mentioned this issue Oct 1, 2022
Merged
@guizmaii
Copy link
Member

@ThijsBroersen I see that your PR has been merged. Can we close this issue now?

@plokhotnyuk
Copy link
Contributor

Fixed by #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plokhotnyuk @guizmaii @ThijsBroersen