Skip to content

Commit 70e512e

Browse files
zhangzujianzhangzujian
committed
fix github actions workflows (kubeovn#2363)
1 parent 6ac19b9 commit 70e512e

File tree

3 files changed

+57
-41
lines changed

3 files changed

+57
-41
lines changed

‎.github/workflows/build-x86-image.yaml

+35-28
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ concurrency:
2626
cancel-in-progress: true
2727

2828
env:
29-
GOSEC_VERSION: '2.14.0'
30-
HELM_VERSION: v3.10.1
29+
GOSEC_VERSION: '2.15.0'
30+
HELM_VERSION: v3.10.3
3131

3232
jobs:
3333
build-kube-ovn:
@@ -60,7 +60,12 @@ jobs:
6060
6161
- name: Install gosec
6262
run: |
63-
curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s -- -b $(go env GOPATH)/bin 'v${{ env.GOSEC_VERSION }}'
63+
tmp=$(mktemp -d)
64+
archive="gosec_${{ env.GOSEC_VERSION }}_$(go env GOHOSTOS)_$(go env GOHOSTARCH).tar.gz"
65+
wget -q -O "$tmp/$archive" https://github.com/securego/gosec/releases/download/v${{ env.GOSEC_VERSION }}/$archive
66+
tar --no-same-owner -C "$tmp" -xzf "$tmp/$archive"
67+
install "$tmp/gosec" /usr/local/bin
68+
rm -rf $tmp
6469
6570
- name: Build
6671
run: |
@@ -95,7 +100,9 @@ jobs:
95100

96101
k8s-conformance-e2e:
97102
name: Kubernetes Conformance E2E
98-
needs: build-kube-ovn
103+
needs:
104+
- build-kube-ovn
105+
- build-e2e-binaries
99106
runs-on: ubuntu-22.04
100107
timeout-minutes: 60
101108
strategy:
@@ -112,9 +119,11 @@ jobs:
112119
- uses: actions/checkout@v3
113120

114121
- name: Create the default branch directory
122+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
115123
run: mkdir -p test/e2e/source
116124

117125
- name: Check out the default branch
126+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
118127
uses: actions/checkout@v3
119128
with:
120129
ref: ${{ github.event.repository.default_branch }}
@@ -143,18 +152,14 @@ jobs:
143152
run: echo "GO_FULL_VER=$(go version | awk '{print $3}')" >> "$GITHUB_ENV"
144153

145154
- name: Go cache
146-
uses: actions/cache@v3
155+
uses: actions/cache/restore@v3
147156
with:
148157
path: |
149158
~/.cache/go-build
150159
~/go/pkg/mod
151-
key: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-${{ hashFiles(format('{0}/**/go.sum', env.E2E_DIR)) }}
160+
key: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-${{ hashFiles(format('{0}/**/go.sum', env.E2E_DIR)) }}
152161
restore-keys: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-
153162

154-
- name: Build e2e binaries
155-
working-directory: ${{ env.E2E_DIR }}
156-
run: make e2e-compile
157-
158163
- name: Install kind
159164
uses: helm/kind-action@v1
160165
with:
@@ -190,7 +195,9 @@ jobs:
190195
k8s-netpol-e2e:
191196
name: Kubernetes Network Policy E2E
192197
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'network policy')
193-
needs: build-kube-ovn
198+
needs:
199+
- build-kube-ovn
200+
- build-e2e-binaries
194201
runs-on: ubuntu-22.04
195202
timeout-minutes: 60
196203
strategy:
@@ -204,9 +211,11 @@ jobs:
204211
- uses: actions/checkout@v3
205212

206213
- name: Create the default branch directory
214+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
207215
run: mkdir -p test/e2e/source
208216

209217
- name: Check out the default branch
218+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
210219
uses: actions/checkout@v3
211220
with:
212221
ref: ${{ github.event.repository.default_branch }}
@@ -235,18 +244,14 @@ jobs:
235244
run: echo "GO_FULL_VER=$(go version | awk '{print $3}')" >> "$GITHUB_ENV"
236245

237246
- name: Go cache
238-
uses: actions/cache@v3
247+
uses: actions/cache/restore@v3
239248
with:
240249
path: |
241250
~/.cache/go-build
242251
~/go/pkg/mod
243252
key: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-${{ hashFiles(format('{0}/**/go.sum', env.E2E_DIR)) }}
244253
restore-keys: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-
245254

246-
- name: Build e2e binaries
247-
working-directory: ${{ env.E2E_DIR }}
248-
run: make e2e-compile
249-
250255
- name: Install kind
251256
uses: helm/kind-action@v1
252257
with:
@@ -292,9 +297,11 @@ jobs:
292297
- uses: actions/checkout@v3
293298

294299
- name: Create the default branch directory
300+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
295301
run: mkdir -p test/e2e/source
296302

297303
- name: Check out the default branch
304+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
298305
uses: actions/checkout@v3
299306
with:
300307
ref: ${{ github.event.repository.default_branch }}
@@ -339,7 +346,9 @@ jobs:
339346

340347
kube-ovn-conformance-e2e:
341348
name: Kube-OVN Conformance E2E
342-
needs: build-kube-ovn
349+
needs:
350+
- build-kube-ovn
351+
- build-e2e-binaries
343352
runs-on: ubuntu-22.04
344353
timeout-minutes: 30
345354
strategy:
@@ -353,9 +362,11 @@ jobs:
353362
- uses: actions/checkout@v3
354363

355364
- name: Create the default branch directory
365+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
356366
run: mkdir -p test/e2e/source
357367

358368
- name: Check out the default branch
369+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
359370
uses: actions/checkout@v3
360371
with:
361372
ref: ${{ github.event.repository.default_branch }}
@@ -379,18 +390,14 @@ jobs:
379390
run: echo "GO_FULL_VER=$(go version | awk '{print $3}')" >> "$GITHUB_ENV"
380391

381392
- name: Go cache
382-
uses: actions/cache@v3
393+
uses: actions/cache/restore@v3
383394
with:
384395
path: |
385396
~/.cache/go-build
386397
~/go/pkg/mod
387398
key: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-${{ hashFiles(format('{0}/**/go.sum', env.E2E_DIR)) }}
388399
restore-keys: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-
389400

390-
- name: Build e2e binaries
391-
working-directory: ${{ env.E2E_DIR }}
392-
run: make e2e-compile
393-
394401
- name: Install kind
395402
uses: helm/kind-action@v1
396403
with:
@@ -570,8 +577,10 @@ jobs:
570577
run: sh dist/images/cleanup.sh
571578

572579
cilium-chaining-e2e:
573-
needs: build-kube-ovn
574580
name: Cilium Chaining E2E
581+
needs:
582+
- build-kube-ovn
583+
- build-e2e-binaries
575584
runs-on: ubuntu-22.04
576585
timeout-minutes: 30
577586
steps:
@@ -581,9 +590,11 @@ jobs:
581590
version: '${{ env.HELM_VERSION }}'
582591

583592
- name: Create the default branch directory
593+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
584594
run: mkdir -p test/e2e/source
585595

586596
- name: Check out the default branch
597+
if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
587598
uses: actions/checkout@v3
588599
with:
589600
ref: ${{ github.event.repository.default_branch }}
@@ -612,18 +623,14 @@ jobs:
612623
run: echo "GO_FULL_VER=$(go version | awk '{print $3}')" >> "$GITHUB_ENV"
613624

614625
- name: Go cache
615-
uses: actions/cache@v3
626+
uses: actions/cache/restore@v3
616627
with:
617628
path: |
618629
~/.cache/go-build
619630
~/go/pkg/mod
620631
key: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-${{ hashFiles(format('{0}/**/go.sum', env.E2E_DIR)) }}
621632
restore-keys: ${{ runner.os }}-e2e-${{ env.GO_FULL_VER }}-x86-
622633

623-
- name: Build e2e binaries
624-
working-directory: ${{ env.E2E_DIR }}
625-
run: make e2e-compile
626-
627634
- name: Install kind
628635
uses: helm/kind-action@v1
629636
with:

‎.github/workflows/codeql-analysis.yml

+10-5
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ jobs:
3636
# a pull request then we can checkout the head.
3737
fetch-depth: 2
3838

39+
- uses: actions/setup-go@v3
40+
with:
41+
go-version-file: go.mod
42+
check-latest: true
43+
3944
# Initializes the CodeQL tools for scanning.
4045
- name: Initialize CodeQL
4146
uses: github/codeql-action/init@v1
@@ -48,8 +53,8 @@ jobs:
4853

4954
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
5055
# If this step fails, then you should remove it and run the build manually (see below)
51-
- name: Autobuild
52-
uses: github/codeql-action/autobuild@v1
56+
# - name: Autobuild
57+
# uses: github/codeql-action/autobuild@v2
5358

5459
# ℹ️ Command-line programs to run using the OS shell.
5560
# 📚 https://git.io/JvXDl
@@ -58,9 +63,9 @@ jobs:
5863
# and modify them (or add more) to build your code if your project
5964
# uses a compiled language
6065

61-
#- run: |
62-
# make bootstrap
63-
# make release
66+
- name: Build
67+
run: |
68+
make build-go
6469
6570
- name: Perform CodeQL Analysis
6671
uses: github/codeql-action/analyze@v1

‎Makefile

+12-8
Original file line numberDiff line numberDiff line change
@@ -245,15 +245,12 @@ kind-untaint-control-plane:
245245
kind-install: kind-load-image
246246
kubectl config use-context kind-kube-ovn
247247
@$(MAKE) kind-untaint-control-plane
248-
bash dist/images/install.sh
248+
sed 's/VERSION=.*/VERSION=$(VERSION)/' dist/images/install.sh | bash
249249
kubectl describe no
250250

251251
.PHONY: kind-install-dev
252252
kind-install-dev:
253-
$(call kind_load_image,kube-ovn,$(REGISTRY)/kube-ovn:$(DEV_TAG))
254-
kubectl config use-context kind-kube-ovn
255-
@$(MAKE) kind-untaint-control-plane
256-
sed 's/VERSION=.*/VERSION=$(DEV_TAG)/' dist/images/install.sh | bash
253+
@VERSION=$(DEV_TAG) $(MAKE) kind-install
257254

258255
.PHONY: kind-install-ipv4
259256
kind-install-ipv4: kind-install-overlay-ipv4
@@ -268,8 +265,8 @@ kind-install-ovn-ic: kind-load-image kind-install
268265
sed -e 's/10.16.0/10.18.0/g' \
269266
-e 's/10.96.0/10.98.0/g' \
270267
-e 's/100.64.0/100.68.0/g' \
271-
dist/images/install.sh | \
272-
bash
268+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
269+
dist/images/install.sh | bash
273270
kubectl describe no
274271

275272
docker run -d --name ovn-ic-db --network kind $(REGISTRY)/kube-ovn:$(VERSION) bash start-ic-db.sh
@@ -300,6 +297,7 @@ kind-install-underlay-ipv4: kind-disable-hairpin kind-load-image kind-untaint-co
300297
-e 's@^[[:space:]]*POD_GATEWAY=.*@POD_GATEWAY="$(KIND_IPV4_GATEWAY)"@' \
301298
-e 's@^[[:space:]]*EXCLUDE_IPS=.*@EXCLUDE_IPS="$(KIND_IPV4_EXCLUDE_IPS)"@' \
302299
-e 's@^VLAN_ID=.*@VLAN_ID="0"@' \
300+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
303301
dist/images/install.sh | \
304302
ENABLE_VLAN=true VLAN_NIC=eth0 bash
305303
kubectl describe no
@@ -311,6 +309,7 @@ kind-install-underlay-hairpin-ipv4: kind-enable-hairpin kind-load-image kind-unt
311309
-e 's@^[[:space:]]*POD_GATEWAY=.*@POD_GATEWAY="$(KIND_IPV4_GATEWAY)"@' \
312310
-e 's@^[[:space:]]*EXCLUDE_IPS=.*@EXCLUDE_IPS="$(KIND_IPV4_EXCLUDE_IPS)"@' \
313311
-e 's@^VLAN_ID=.*@VLAN_ID="0"@' \
312+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
314313
dist/images/install.sh | \
315314
ENABLE_VLAN=true VLAN_NIC=eth0 bash
316315
kubectl describe no
@@ -329,6 +328,7 @@ kind-install-underlay-ipv6: kind-disable-hairpin kind-load-image kind-untaint-co
329328
-e 's@^[[:space:]]*POD_GATEWAY=.*@POD_GATEWAY="$(KIND_IPV6_GATEWAY)"@' \
330329
-e 's@^[[:space:]]*EXCLUDE_IPS=.*@EXCLUDE_IPS="$(KIND_IPV6_EXCLUDE_IPS)"@' \
331330
-e 's@^VLAN_ID=.*@VLAN_ID="0"@' \
331+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
332332
dist/images/install.sh | \
333333
IPV6=true ENABLE_VLAN=true VLAN_NIC=eth0 bash
334334

@@ -339,6 +339,7 @@ kind-install-underlay-hairpin-ipv6: kind-enable-hairpin kind-load-image kind-unt
339339
-e 's@^[[:space:]]*POD_GATEWAY=.*@POD_GATEWAY="$(KIND_IPV6_GATEWAY)"@' \
340340
-e 's@^[[:space:]]*EXCLUDE_IPS=.*@EXCLUDE_IPS="$(KIND_IPV6_EXCLUDE_IPS)"@' \
341341
-e 's@^VLAN_ID=.*@VLAN_ID="0"@' \
342+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
342343
dist/images/install.sh | \
343344
IPV6=true ENABLE_VLAN=true VLAN_NIC=eth0 bash
344345

@@ -356,6 +357,7 @@ kind-install-underlay-dual: kind-disable-hairpin kind-load-image kind-untaint-co
356357
-e 's@^[[:space:]]*POD_GATEWAY=.*@POD_GATEWAY="$(KIND_IPV4_GATEWAY),$(KIND_IPV6_GATEWAY)"@' \
357358
-e 's@^[[:space:]]*EXCLUDE_IPS=.*@EXCLUDE_IPS="$(KIND_IPV4_EXCLUDE_IPS),$(KIND_IPV6_EXCLUDE_IPS)"@' \
358359
-e 's@^VLAN_ID=.*@VLAN_ID="0"@' \
360+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
359361
dist/images/install.sh | \
360362
DUAL_STACK=true ENABLE_VLAN=true VLAN_NIC=eth0 bash
361363

@@ -366,6 +368,7 @@ kind-install-underlay-hairpin-dual: kind-enable-hairpin kind-load-image kind-unt
366368
-e 's@^[[:space:]]*POD_GATEWAY=.*@POD_GATEWAY="$(KIND_IPV4_GATEWAY),$(KIND_IPV6_GATEWAY)"@' \
367369
-e 's@^[[:space:]]*EXCLUDE_IPS=.*@EXCLUDE_IPS="$(KIND_IPV4_EXCLUDE_IPS),$(KIND_IPV6_EXCLUDE_IPS)"@' \
368370
-e 's@^VLAN_ID=.*@VLAN_ID="0"@' \
371+
-e 's/VERSION=.*/VERSION=$(VERSION)/' \
369372
dist/images/install.sh | \
370373
DUAL_STACK=true ENABLE_VLAN=true VLAN_NIC=eth0 bash
371374

@@ -396,7 +399,8 @@ kind-install-cilium: kind-load-image kind-untaint-control-plane
396399
--set cni.configMap=cni-configuration
397400
kubectl -n kube-system rollout status ds cilium --timeout 300s
398401
bash dist/images/cilium.sh
399-
ENABLE_LB=false ENABLE_NP=false WITHOUT_KUBE_PROXY=true CNI_CONFIG_PRIORITY=10 bash dist/images/install.sh
402+
sed 's/VERSION=.*/VERSION=$(VERSION)/' dist/images/install.sh | \
403+
ENABLE_LB=false ENABLE_NP=false WITHOUT_KUBE_PROXY=true CNI_CONFIG_PRIORITY=10 bash
400404
kubectl describe no
401405

402406
.PHONY: kind-reload

0 commit comments

Comments
 (0)