This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Oracle quoting fix for values with single quotes #7177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single quotes need to be handled differently $str = 'foo \'bar'; echo 'select '.$oracleAdapterPlatform->quoteTrustedValue($str).'from dual';//sql string won't run in Oracle(11.2.0.4.0 in this case) outputs: select 'foo \'bar' from dual needs to output: select 'foo ''bar' from dual
|
Can you add a test case ? |
|
Sorry I'm still a little new to pull requests. Do you mean an assertion in the Oracle unit test? |
|
You need to add a test case in https://github.com/zendframework/zf2/blob/master/tests/ZendTest/Db/Adapter/Platform/OracleTest.php so we don't have any regressions. |
|
Ah yes, I see. |
|
Priority issue at work, will fix delete assertions in unit test asap |
|
👍 |
weierophinney
added a commit
that referenced
this pull request
Feb 25, 2015
Oracle quoting fix for values with single quotes
weierophinney
added a commit
that referenced
this pull request
Feb 25, 2015
|
Merged to develop for release with 2.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single quotes need to be handled differently
$str = 'foo 'bar';
echo 'select '.$oracleAdapterPlatform->quoteTrustedValue($str).'from dual';//sql string won't run in Oracle(11.2.0.4.0 in this case)
outputs: select 'foo 'bar' from dual
needs to output: select 'foo ''bar' from dual