This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
ArrayUtils performance tweak #6900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -257,7 +257,7 @@ public static function iteratorToArray($iterator, $recursive = true) | |||
| public static function merge(array $a, array $b, $preserveNumericKeys = false) | |||
| { | |||
| foreach ($b as $key => $value) { | |||
| if (array_key_exists($key, $a)) { | |||
| if (isset($a[$key]) || array_key_exists($key, $a)) { | |||
| if (is_int($key) && !$preserveNumericKeys) { | |||
There was a problem hiding this comment.
Can you also swap this conditional?
There was a problem hiding this comment.
See #6905. I saw too late you already closed this one...
Ocramius
added a commit
that referenced
this pull request
Nov 20, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 20, 2014
|
@Pittiplatsch merged, thanks! |
Closed
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…r function call
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…rformance-tweaks' into develop Close zendframework/zendframework#6900 Forward port zendframework/zendframework#6900
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.