This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix for FilesSize validator usage with Input #6731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,6 +98,16 @@ public function isValid($value, $file = null) | |||
| $size = $this->getSize(); | |||
| foreach ($value as $files) { | |||
| // Is file readable ? | |||
There was a problem hiding this comment.
Move "Is file readable" comment on after your code addition
|
need test |
|
I've added a test. |
|
Apparently one of the Cache test fails on PHP 5.5. I don't see any direct links with the changed code though… |
| } | ||
|
|
||
| $min = $this->getMin(true); | ||
| $max = $this->getMax(true); | ||
| $size = $this->getSize(); | ||
| foreach ($value as $files) { | ||
| if (is_array($files)) { | ||
| if (!isset($files['tmp_name']) || !isset($files['name'])) { | ||
| throw new Exception\InvalidArgumentException( |
There was a problem hiding this comment.
This particular path seems to be uncovered by the test
There was a problem hiding this comment.
Not any more, as of afbfac7
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
fix for FilesSize validator usage with Input
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
|
Merged to develop for release with 2.4. |
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…filefilessize fix for FilesSize validator usage with Input
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem with
FilesSizewhen used as validator for aFileInput: the validator doesn't accept input in the$_FILESformat. It expects a filename or an array of filenames.This PR adds support for the
$_FILESformat to theFilesSizevalidator.