Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

#6386 Add Priority system for validators #6496

Closed
wants to merge 2 commits into from
Closed

#6386 Add Priority system for validators #6496

wants to merge 2 commits into from

Conversation

MadCat34
Copy link
Contributor

This PR is for #6386

I made lot of shit on previous branch...
I have deleted it and have just recreated it...

@Ocramius Ocramius mentioned this pull request Jul 29, 2014
Closed
@ezimuel ezimuel modified the milestones: 2.3.2, 2.4.0 Aug 6, 2014
@adamlundrigan adamlundrigan mentioned this pull request Nov 17, 2014
Closed
@adamlundrigan
Copy link
Contributor

Could you also write a blurb for the documentation (here? https://raw.githubusercontent.com/zendframework/zf2-documentation/master/docs/languages/en/modules/zend.validator.rst) about validator priorities?

@RomainBastide
Copy link

Hi Adam,
Ok for documentation.
But I need to work again on this point...Some tests have failed ...

Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - validator chain should reject invalid callbacks
1c72791
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - minor cleanups, simplifying checks around $callback v…
3f7ced5 
…alidity
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - adding @group annotations for newly introduced tests
93992f0
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - inlining $this->attach() and $this->plugin() calls
53aa76f
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - reverting minor bc-break (attach method should keep a…
9244b02 
… compatible signature)
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - removing useless test that checks against an invalid ty…
ceded40 
…pe-hint usage
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
#6496 #6386 - reverting unrelated test changes
d0001c8
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
Merge branch 'feature/#6386-#6496-support-validator-priority' into de…
18f8762 
…velop

Close #6386
Close #6496
@Ocramius Ocramius self-assigned this Nov 19, 2014
@Ocramius
Copy link
Member

@MadCat34 I've tweaked, rebased and merged your PR into develop at 18f8762, thanks!

@Ocramius Ocramius closed this Nov 19, 2014
@RomainBastide
Copy link

Thanks @Ocramius :-)
I will look what you've done to understand what I missed and how I could have done better :-)

@Ocramius
Copy link
Member

@RomainBastide I just did some house-holding, no substantial changes :-)

Ocramius added a commit to Ocramius/zf2 that referenced this pull request Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - adding test for uncovered `Va…
ab6cd16 
…lidatorChain#merge()` method, which presents internal type mismatches
Ocramius added a commit to Ocramius/zf2 that referenced this pull request Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - fixing values passed internal…
ae6a7c6 
…ly to `ValidatorChain#attach()` by `ValidatorChain#merge()`
This was referenced Nov 22, 2014
Closed
Closed
Merged
Ocramius added a commit to Ocramius/zf2 that referenced this pull request Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - ValidatorChain must be clon…
300a4b1 
…eable
Ocramius added a commit to Ocramius/zf2 that referenced this pull request Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - ValidatorChain can be clone…
b95a49c 
…d, as the validator chain is now deep-cloned
Ocramius added a commit that referenced this pull request Nov 22, 2014
@Ocramius
Merge pull request #6912 from Ocramius/hotfix/#6386-#6496-validator-c…
a6ec0bd 
…hain-merge-type-mismatch

Hotfix: #6386 #6496 validator chain merge type mismatch
@adamlundrigan
Copy link
Contributor

This PR causes a failure on hhvm-nightly: https://travis-ci.org/zendframework/zf2/jobs/57417573#L719

1) ZendTest\InputFilter\ArrayInputTest::testIsValidReturnsFalseIfValidationChainFails
Undefined index: 0
/home/travis/build/zendframework/zf2/library/Zend/Validator/ValidatorChain.php:162

Runs fine on hhvm, so I guess something changed in HHVM 3.5.0?

@kehigginbotham kehigginbotham mentioned this pull request May 14, 2015
Closed
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - v…
d533dcb 
…alidator chain should reject invalid callbacks
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - m…
f0c42b7 
…inor cleanups, simplifying checks around `$callback` validity
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - a…
0cc783e 
…dding `@group` annotations for newly introduced tests
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - i…
d570801 
…nlining `$this->attach()` and `$this->plugin()` calls
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - r…
eeb8fb9 
…everting minor bc-break (`attach` method should keep a compatible signature)
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - r…
8e4e1ba 
…emoving useless test that checks against an invalid type-hint usage
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - r…
4ac44d6 
…everting unrelated test changes
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'feature/zendframework/zendframework#6386-zendframework/…
9b5e8eb 
…zendframework#6496-support-validator-priority' into develop

Close zendframework/zendframework#6386
Close zendframework/zendframework#6496
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - a…
a639c2e 
…dding test for uncovered `ValidatorChain#merge()` method, which presents internal type mismatches
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - f…
c15d5d6 
…ixing values passed internally to `ValidatorChain#attach()` by `ValidatorChain#merge()`
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - `…
a19c484 
…ValidatorChain` must be cloneable
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - `…
9ba3524 
…ValidatorChain` can be cloned, as the validator chain is now deep-cloned
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@Ocramius
Merge pull request zendframework/zendframework#6912 from Ocramius/hot…
34571c8 
…fix/zendframework/zendframework#6386-zendframework/zendframework#6496-validator-chain-merge-type-mismatch

Hotfix: zendframework/zendframework#6386 zendframework/zendframework#6496 validator chain merge type mismatch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement Validator
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MadCat34 @adamlundrigan @RomainBastide @Ocramius @ezimuel