Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix: Undefined field in Zend\Http\Header\Origin #6480

Closed

Conversation

localheinz
Copy link
Member

Field $value is used, but never declared.

@Ocramius Ocramius added this to the 2.3.2 milestone Jul 22, 2014
@micheh
Copy link
Contributor

micheh commented Jul 22, 2014

You should probably use the protected visibility (like the other Header classes).

mattmakins pushed a commit to mattmakins/zf2 that referenced this pull request Jul 24, 2014
@Ocramius Ocramius mentioned this pull request Aug 4, 2014
@Ocramius Ocramius self-assigned this Aug 4, 2014
@Ocramius
Copy link
Member

Ocramius commented Aug 4, 2014

You should probably use the protected visibility (like the other Header classes).

It can be done later if someone needs it IMO.

mattmakins pushed a commit to mattmakins/zf2 that referenced this pull request Aug 4, 2014
update OriginTest to test getFieldValue fix
mattmakins pushed a commit to mattmakins/zf2 that referenced this pull request Aug 4, 2014
This reverts commit 2f01609.
mattmakins pushed a commit to mattmakins/zf2 that referenced this pull request Aug 4, 2014
Ocramius added a commit that referenced this pull request Aug 6, 2014
@Ocramius Ocramius closed this in ac5f6bc Aug 6, 2014
@Ocramius
Copy link
Member

Ocramius commented Aug 6, 2014

@localheinz thanks!

Ocramius pushed a commit that referenced this pull request Aug 6, 2014
Ocramius pushed a commit that referenced this pull request Aug 6, 2014
update OriginTest to test getFieldValue fix
Ocramius pushed a commit that referenced this pull request Aug 6, 2014
This reverts commit 2f01609.
Ocramius pushed a commit that referenced this pull request Aug 6, 2014
@localheinz localheinz deleted the bugfixes/undefined-field branch October 12, 2014 12:33
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
update OriginTest to test getFieldValue fix
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
This reverts commit 2f0160915ae480aad13cb0ce29b1e819dbeb29a8.
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants