This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Digit filter should ignore boolean input #6277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param string $value | ||
| * @return string|mixed | ||
| */ | ||
| public function filter($value) | ||
| { | ||
| if (!is_scalar($value)) { | ||
| if (! (is_int($value) || is_float($value) || is_string($value))) { |
There was a problem hiding this comment.
As noted in our IRC conversation yesterday, I'd argue that if $value is an integer, you should do a return (string) $value;, and skip the regex. Integers are always series of digits; the main thing is ensuring that a string value is returned in that case, so that subsequent filters can operate on it.
Ocramius
added a commit
that referenced
this pull request
May 20, 2014
|
Merged manually into master via cherry-pick. |
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…ould-ignore-booleans-backport' Close zendframework/zendframework#6277
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…ould-ignore-booleans' into develop Close zendframework/zendframework#6277 Forward Port zendframework/zendframework#6277
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The digits filter should only be filtering things that can represent digits. Booleans do not represent digits and should pass through unchanged.