Created Explode Strategy for hydrator

[ojhaujjwal]

Too simple and self-explanatory.
Please see the tests.

[Martin-P]

This is a general description, it does not describe what this method does.

[ojhaujjwal]

See below

[Martin-P]

Just trying to break things 😃

$strategy = new ExplodeStrategy();
$strategy->setValueDelimiter(null);
$result   = $strategy->hydrate('foo');
// Warning: explode(): Empty delimiter in...

$strategy = new ExplodeStrategy();
$strategy->setValueDelimiter('');
$result   = $strategy->hydrate('foo');
// Warning: explode(): Empty delimiter in...

Explode has a third parameter (http://www.php.net/explode), should that be covered as well?

[ojhaujjwal]

@Martin-P Thank you for providing the details.

[ojhaujjwal]

@Martin-P Hey. I have done some changes. Please comment.

[ojhaujjwal]

Will this PR get merged for 2.4?

[Martin-P]

Not sure if it needs implementation, but should 1 (as a string) be allowed as well?

$strategy->setExplodeLimit('1');

[ojhaujjwal]

Not sure.

[ojhaujjwal]

We may use is_numeric instead of is_int.

[Martin-P]

is_numeric allows too many things, like e.g. hexadecimal values. If you implement it, ctype_digit is more accurate.

if (!ctype_digit((string) $explodeLimit)) {

However ctype_digit does not allow negative values:

var_dump(ctype_digit('-1')); // false

Casting to int could also be an option, but I'm not sure that is the way to do this.

[ojhaujjwal]

We need some expert's help.
ping @Ocramius

[Maks3w]

You could cast to int and replace the default value of nullwith 0. If you cast everything to int the implementation will be more simple

[adamlundrigan]

This will need a documentation PR to add it to the list of available implementations

[adamlundrigan]

@ojhaujjwal @weierophinney does this seem like a common enough use case to warrant including in core?

Just a thought: would it be better to provide a more generalized adapter to Zend\Serializer, and add some sort of array-to-separator imploder there? That would take care of this use case plus make other serialization formats available with no extra effort

[ojhaujjwal]

@adamlundrigan One use case is that it can be used in forms to take comma separated input from the user.

[samsonasik]

2015 ;)