decompress() Zend/Filter/Compress/Zip fix #6026
Conversation
decompress didn't work when a valid parameter was given. It relied on archive that was stored in class. This fixes it.
|
Hmm why does the build fail?, I didn't make a drastic change. |
|
|
||
| if (empty($archive) || !file_exists($archive)) { | ||
| throw new Exception\RuntimeException('ZIP Archive not found'); | ||
| } | ||
|
|
||
| $archive = str_replace(array('/', '\\'), DIRECTORY_SEPARATOR, realpath($content)); | ||
|
|
There was a problem hiding this comment.
This space already existed i just moved it, do i have to do anything to get your comment applied?
|
Please add a unit test |
|
The unit test for Zip already exists, and calls this method with a param |
|
Add a unit test showing your use case |
|
Is this better? |
|
Sorry, I didn't quite get the trailing spaces part till now. I hope this makes the deal. |
|
Go Travis, Go |
|
trailing spaces seems fixed in test. one of the three builds fails for a reason unknown to me |
|
@sjerdo the cache failure is annoying - can't do much about it, it is not related with this PR. |
|
Can anyone trigger the Travis CI to re-test this push? It should've passed. |
|
@thoys no need to re-run travis. It was just the usual cache race condition. |
|
Travis relunched now that tests are enabled |
…-archive-path-fixes' Close zendframework/zendframework#6026
…-archive-path-fixes' into develop Close zendframework/zendframework#6026 Forward Port zendframework/zendframework#6026
decompress didn't work when a valid parameter was given. It relied on archive that was stored in class.
This fixes it.