[2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3 #5604

samsonasik · 2013-12-11T07:42:32Z

Per @weierophinney change on af3e982 at PR #5602

macnibblet · 2013-12-11T08:55:26Z

Don't forget this guy https://github.com/zendframework/zf2/blob/master/library/Zend/Session/Container.php

samsonasik · 2013-12-11T09:04:34Z

@macnibblet done ;)

macnibblet · 2013-12-11T09:06:55Z

Ehm, shouldn't you be removing all the class_aliases and using the proper implementation instead ?

macnibblet · 2013-12-11T09:11:22Z

You should do a grep on all instances of version_compare in the library folder because there are many more instances

samsonasik · 2013-12-11T09:36:20Z

@macnibblet all version_compare checked. I'm not sure about removing class_aliases, any suggestions for it that need to be removed / updated ?

macnibblet · 2013-12-11T09:37:45Z

The reason that we have class_aliases is because we need to fix a bug in PHP, if we bump the minor version we don't need to use those fixes thus they should be removed...

samsonasik · 2013-12-11T09:48:46Z

@macnibblet updated. please let me know if I missed something ^^

samsonasik · 2013-12-11T09:56:28Z

@macnibblet wait, last commit cause travis error because I remove class_aliases, I will reset it and check again.

macnibblet · 2013-12-11T09:57:21Z

You are going to need to fix tests aswell :)

samsonasik · 2013-12-11T10:55:29Z

@macnibblet updated. travis green again ;)

gws · 2013-12-11T18:54:23Z

tests/ZendTest/Validator/File/IsImageTest.php

        ) {
            return __DIR__ . '/_files/magic.lte.5.3.10.mime';
        }

        // Ubuntu has backported the changes in 12.04 to PHP 5.3.10.
-        if (strpos(PHP_VERSION, 'ubuntu') !== false && version_compare(PHP_VERSION, '5.3.10', '>=')) {
+        if (strpos(PHP_VERSION, 'ubuntu') !== false) {
            return __DIR__ . '/_files/magic.lte.5.3.10.mime';
        }


I think that whole block can go away now.

I'm not sure about it //cc @weierophinney

@gws I think ubuntu check should still exist because version_compare is check for PHP_VERSION >= 5.3.10 , not < , so, the conditional still valid, and we need to only remove the version_compare check because we are already in PHP_VERSION >= 5.3.23. /cc @weierophinney

My thinking: the PHP version requirements in ZF2 are now beyond the magic database change in 5.3.11 for the 5.3.x line, regardless of Ubuntu's backport to 5.3.10. The only remaining supported version which requires the old magic file format is 5.4.0, which is tested for in the first block.

@weierophinney any suggestions for this ?

@gws Ok, now removed as your suggestion. thanks.

samsonasik · 2014-01-19T19:45:14Z

rebased agains develop cause #5724

Maks3w · 2014-02-15T14:48:43Z

tests/ZendTest/Crypt/Password/BcryptTest.php

@@ -129,8 +126,6 @@ public function testVerifyFailureVersion()
                'backwards compatibility settings.'
            );
            $this->bcrypt->verify('test', $hash);
-        } else {


Remove if too.

samsonasik · 2014-02-15T15:07:12Z

@Maks3w done ;)

Maks3w · 2014-02-15T15:11:40Z

Remove this file too please https://github.com/samsonasik/zf2/blob/change/php-require-version/library/Zend/Session/Storage/SessionArrayStorage/PhpReferenceCompatibility.php

samsonasik · 2014-02-15T15:16:09Z

@Maks3w removed ;)

samsonasik · 2014-02-15T16:00:04Z

@Maks3w done, now removed, I did :
1. move Zend/Stdlib/ArrayObject/PhpReferenceCompatibility.php into Zend/Stdlib/ArrayObject.php and remove the Zend/Stdlib/ArrayObject/PhpReferenceCompatibility.php
2. move Zend/Session/Storage/SessionArrayStorage/PhpReferenceCompatibility.php into Zend/Session/Storage/SessionArrayStorage.php and remove Zend/Session/Storage/SessionArrayStorage/PhpReferenceCompatibility.php

Please let me know if I missed something ^^

Maks3w · 2014-02-15T20:27:18Z

library/Zend/Session/Container.php

@@ -23,6 +19,6 @@ class_alias('Zend\Session\Container\PhpReferenceCompatibility', 'Zend\Session\Ab
 * Additionally, expiries may be absolute TTLs or measured in "hops", which
 * are based on how many times the key or container were accessed.
 */
-class Container extends AbstractBaseContainer
+class Container extends PhpReferenceCompatibility


include the code from the parent class here

and remove the old class

@Maks3w done. code included from the parent class, and old class removed.

HardieBoeve · 2014-02-15T22:09:19Z

Why not set the minimum to php 5.4? And maybe even better to 5.5 cause 5.3 is already deprecated for almost an year, and 5.4 will be soon deprecated with the release of 5.6.

samsonasik · 2014-02-15T22:11:50Z

@HardieBoeve 5.4 will be for ZF3 //cc @weierophinney ;)

HardieBoeve · 2014-02-15T22:15:29Z

ok :) .. but would it not be better for ZF3 to require at least PHP5.5? Because 5.4 is almost eol.

blanchonvincent · 2014-02-15T22:18:14Z

@HardieBoeve "Adoption of PHP 5.4 and/or PHP 5.5. Right now, we want to target 5.4
for ZF3, but the main stumbling block is adoption. Right now, most LTS
distributions are on PHP 5.3.3, and may or may not have new releases
by then; we don't want to risk having a version that nobody can adopt." by @weierophinney

HardieBoeve · 2014-02-15T23:03:57Z

@blanchonvincent thats sadly true .....

But what is the time schedule for releasing ZF3? Will it be this year? Else i personally think it will be pointless to adopt an eol version of php, because most developers are using other resources than the main resources an LTS comes with to get the latest version, but also i know some not, and yes .. when closing them out will be not an good idea.

Ocramius · 2014-02-15T23:11:31Z

Afaik, only RHEL will be 5.4, and RHEL is designed to run ancient systems anyway (not for what is yet to be built), so 5.5 could eventually be a good candidate. I'd move this to the mailing list though.

HardieBoeve · 2014-02-15T23:20:23Z

@Ocramius 👍

…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3

gws reviewed Dec 11, 2013
View reviewed changes

samsonasik mentioned this pull request Dec 13, 2013

Update minimum required PHP version to 5.3.23 #5602

Merged

samsonasik mentioned this pull request Jan 19, 2014

5.3.3 -> 5.3.23 missing dump #5724

Merged

Maks3w reviewed Feb 15, 2014
View reviewed changes

Maks3w added this to the 2.3.0 milestone Feb 15, 2014

Maks3w reviewed Feb 15, 2014
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3 #5604

[2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3 #5604

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

gws Dec 11, 2013

samsonasik Dec 11, 2013

samsonasik Dec 14, 2013

gws Dec 14, 2013

samsonasik Jan 4, 2014

samsonasik Jan 19, 2014

samsonasik commented Jan 19, 2014

Maks3w Feb 15, 2014

samsonasik commented Feb 15, 2014

Maks3w commented Feb 15, 2014

samsonasik commented Feb 15, 2014

samsonasik commented Feb 15, 2014

Maks3w Feb 15, 2014

Maks3w Feb 15, 2014

samsonasik Feb 15, 2014

HardieBoeve commented Feb 15, 2014

samsonasik commented Feb 15, 2014

HardieBoeve commented Feb 15, 2014

blanchonvincent commented Feb 15, 2014

HardieBoeve commented Feb 15, 2014

Ocramius commented Feb 15, 2014

HardieBoeve commented Feb 15, 2014

[2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3 #5604

[2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3 #5604

Conversation

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

samsonasik commented Dec 11, 2013

macnibblet commented Dec 11, 2013

samsonasik commented Dec 11, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsonasik commented Jan 19, 2014

Choose a reason for hiding this comment

samsonasik commented Feb 15, 2014

Maks3w commented Feb 15, 2014

samsonasik commented Feb 15, 2014

samsonasik commented Feb 15, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HardieBoeve commented Feb 15, 2014

samsonasik commented Feb 15, 2014

HardieBoeve commented Feb 15, 2014

blanchonvincent commented Feb 15, 2014

HardieBoeve commented Feb 15, 2014

Ocramius commented Feb 15, 2014

HardieBoeve commented Feb 15, 2014