Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fixed non-working Spanish validator translation #5557

Closed
wants to merge 3 commits into from

Conversation

poisa
Copy link
Contributor

@poisa poisa commented Nov 28, 2013

This translation contains translation keys from the ZF1 validators NOT the ZF2 ones. This effectively renders them useless since most of the ZF2 translation keys have changed.

I updated all the translations so that they work with ZF2 and also corrected a few grammatical errors and typos.

This translation contains translation keys from the ZF1 validators *NOT* the ZF2 ones. This effectively renders them useless since most of the ZF2 translation keys have changed. 

I updated all the translations so that they work with ZF2 and also corrected a few grammatical errors and typos.
@ghost ghost assigned Maks3w Nov 28, 2013
@samsonasik samsonasik mentioned this pull request Nov 29, 2013
"'%value%' is more than %max% characters long" => "'%value%' tiene más de '%max%' caracteres",
// Zend\Validator\Uri
"Invalid type given. String expected" => "El tipo especificado es incorrecto, el valor debería ser una cadena de texto",
"The input does not appear to be a valid Uri" => "El valor especificado no parecería ser un Uri válido",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no parece"

"Invalid type given, value should be string or integer" => "El tipo especificado es inválido, el valor deberí­a ser una cadena de texto o un entero",
"'%value%' does not appear to be an integer" => "'%value%' no parece ser un entero",
// Zend\Validator\InArray
"The input was not found in the haystack" => "No se ha encontrado en el argumento especificado",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"El valor no se encuentra dentro de los valores permitidos"

@Maks3w
Copy link
Member

Maks3w commented Dec 15, 2013

Gracias @poisa se que muchas de las observaciones que he realizado no se deben a modificaciones tuyas pero dada la complejidad del diff no he podido estar cotejando cuales eran y cuales no.

¿Podrías hacernos el favor de aplicar el feedback de todas formas?

Gracias de nuevo.

@poisa
Copy link
Contributor Author

poisa commented Dec 15, 2013

@Maks3w if you are going over these translations line by line, instead of commenting on them, why not just correct them at the same time? I don't think the original translator is even aware of this PR's existence so they won't be stopping by to correct their work.
Please don't get me wrong, I'm not trying to be offensive but I just got 32 emails from this PR over the span of 40 minutes and think that if you are willing to dedicate this kind of time to this issue why not just do the changes?
I copied 99% of these translations from the previous file so even if you don't fix these small issues I don't think people will even mind. The current ZF2 translations don't work and this PR makes them work, alas with some minor grammatical issues like you are pointing out.
To be honest if I have to go over your comments one by one, it will take me a lot of time, and then you will have to go over them once again to check them, and that will take you a lot of time. That's why I'm suggesting that you do the changes yourself.
Again, I understand what you are doing and respect your work. I just think you are not managing our time well.

@poisa
Copy link
Contributor Author

poisa commented Feb 9, 2014

@Maks3w
Back from holidays. Here are the suggested changes.

Maks3w added a commit that referenced this pull request Feb 15, 2014
@Maks3w Maks3w closed this Feb 15, 2014
weierophinney pushed a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants