Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Hotfix/4740 #4741

Closed
wants to merge 5 commits into from
Closed

Hotfix/4740 #4741

wants to merge 5 commits into from

Conversation

zionsg
Copy link
Contributor

@zionsg zionsg commented Jun 28, 2013

Fix and updated unit tests for Issue #4740

zionsg added 5 commits June 28, 2013 15:51
@zionsg
Remove constructor which skips options for extending classes
186c03a 
'datatype' and 'paramName' options could not be set via constructor for Tag\ReturnTag and Tag\ParamTag due to constructor for Tag which limited options to 'name' and 'description'
@zionsg
Test setting of options via constructor
e1955c7
@zionsg
Test setting of options via constructor
36bd0f0
@zionsg
Test setting of options via constructor
bc4d851
@zionsg
Test setting of options via constructor
2afe6b9
@zionsg zionsg closed this Jun 28, 2013
@zionsg zionsg reopened this Jun 28, 2013
@zionsg
Copy link
Contributor Author

zionsg commented Jun 28, 2013

Would it be alright to remove the constructor for Zend\Code\Generator\DocBlock\Tag\LicenseTag as the setting of options are covered by Zend\Code\Generator\AbstractGenerator? The only issue is the setting of the default value 'license' when name is empty.

@ghost ghost assigned weierophinney Jun 28, 2013
weierophinney added a commit that referenced this pull request Jun 28, 2013
@weierophinney
Merge pull request #4741 from zionsg/hotfix/4740
c9bb5ff 
Hotfix/4740
weierophinney added a commit that referenced this pull request Jun 28, 2013
@weierophinney
Merge branch 'hotfix/4741' into develop
c48de35 
Forward port #4741
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@zionsg @weierophinney