Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Commit 1db6a4f

Browse files
committed
ZendTest string class names changed to ::class
1 parent 4bcc2b6 commit 1db6a4f

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

test/Helper/Placeholder/RegistryTest.php

+7-6
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use PHPUnit\Framework\TestCase;
1313
use Zend\View\Helper\Placeholder\Registry;
1414
use Zend\View\Helper\Placeholder\Container;
15+
use ZendTest\View\Helper\TestAsset;
1516

1617
/**
1718
* Test class for Zend\View\Helper\Placeholder\Registry.
@@ -103,17 +104,17 @@ public function testSetContainerCreatesRegistersContainerInstance()
103104
public function testContainerClassAccessorsSetState()
104105
{
105106
$this->assertEquals(Container::class, $this->registry->getContainerClass());
106-
$this->registry->setContainerClass('ZendTest\View\Helper\TestAsset\MockContainer');
107+
$this->registry->setContainerClass(TestAsset\MockContainer::class);
107108
$this->assertEquals(
108-
'ZendTest\View\Helper\TestAsset\MockContainer',
109+
TestAsset\MockContainer::class,
109110
$this->registry->getContainerClass()
110111
);
111112
}
112113

113114
public function testSetContainerClassThrowsExceptionWithInvalidContainerClass()
114115
{
115116
try {
116-
$this->registry->setContainerClass('ZendTest\View\Helper\TestAsset\BogusContainer');
117+
$this->registry->setContainerClass(TestAsset\BogusContainer::class);
117118
$this->fail('Invalid container classes should not be accepted');
118119
} catch (\Exception $e) {
119120
}
@@ -136,17 +137,17 @@ public function testDeleteContainerReturnsFalseIfContainerDoesNotExist()
136137

137138
public function testUsingCustomContainerClassCreatesContainersOfCustomClass()
138139
{
139-
$this->registry->setContainerClass('ZendTest\View\Helper\TestAsset\MockContainer');
140+
$this->registry->setContainerClass(TestAsset\MockContainer::class);
140141
$container = $this->registry->createContainer('foo');
141-
$this->assertInstanceOf('ZendTest\View\Helper\TestAsset\MockContainer', $container);
142+
$this->assertInstanceOf(TestAsset\MockContainer::class, $container);
142143
}
143144

144145
/**
145146
* @group ZF-10793
146147
*/
147148
public function testSetValueCreateContainer()
148149
{
149-
$this->registry->setContainerClass('ZendTest\View\Helper\TestAsset\MockContainer');
150+
$this->registry->setContainerClass(TestAsset\MockContainer::class);
150151
$data = [
151152
'ZF-10793'
152153
];

test/PhpRendererTest.php

+7-5
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
use Zend\View\Resolver\TemplatePathStack;
2121
use Zend\View\Variables;
2222
use Zend\Filter\FilterChain;
23+
use ZendTest\View\TestAsset\SharedInstance;
24+
use ZendTest\View\TestAsset\Uninvokable;
2325

2426
/**
2527
* @group Zend_View
@@ -219,11 +221,11 @@ public function testPropertyOverloadingShouldProxyToVariablesContainer()
219221
public function testMethodOverloadingShouldReturnHelperInstanceIfNotInvokable()
220222
{
221223
$helpers = new HelperPluginManager(new ServiceManager(), ['invokables' => [
222-
'uninvokable' => 'ZendTest\View\TestAsset\Uninvokable',
224+
'uninvokable' => Uninvokable::class,
223225
]]);
224226
$this->renderer->setHelperPluginManager($helpers);
225227
$helper = $this->renderer->uninvokable();
226-
$this->assertInstanceOf('ZendTest\View\TestAsset\Uninvokable', $helper);
228+
$this->assertInstanceOf(Uninvokable::class, $helper);
227229
}
228230

229231
/**
@@ -232,7 +234,7 @@ public function testMethodOverloadingShouldReturnHelperInstanceIfNotInvokable()
232234
public function testMethodOverloadingShouldInvokeHelperIfInvokable()
233235
{
234236
$helpers = new HelperPluginManager(new ServiceManager(), ['invokables' => [
235-
'invokable' => 'ZendTest\View\TestAsset\Invokable',
237+
'invokable' => Uninvokable::class,
236238
]]);
237239
$this->renderer->setHelperPluginManager($helpers);
238240
$return = $this->renderer->invokable('it works!');
@@ -443,7 +445,7 @@ public function testSharedInstanceHelper()
443445
{
444446
$helpers = new HelperPluginManager(new ServiceManager(), [
445447
'invokables' => [
446-
'sharedinstance' => 'ZendTest\View\TestAsset\SharedInstance',
448+
'sharedinstance' => SharedInstance::class,
447449
],
448450
'shared' => [
449451
'sharedinstance' => false,
@@ -458,7 +460,7 @@ public function testSharedInstanceHelper()
458460

459461
$helpers = new HelperPluginManager(new ServiceManager(), [
460462
'invokables' => [
461-
'sharedinstance' => 'ZendTest\View\TestAsset\SharedInstance',
463+
'sharedinstance' => SharedInstance::class,
462464
],
463465
'shared' => [
464466
'sharedinstance' => true,

0 commit comments

Comments
 (0)