Update legacy _app context #9083

devknoll · 2019-10-15T15:54:09Z

In order to introduce <StrictMode>, we need to clean up the existing warnings. One of those warnings is about the legacy context introduced by _app.js.

We don't actually need this because:

It's an undocumented API
The router is already available via the new-style RouterContext in order to support e.g. the useRouter hook

So this PR removes it from _app, and updates the withRouter function to use the new context object instead.

ijjk · 2019-10-15T15:59:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
buildDuration	15.5s	15.4s	-50ms
nodeModulesSize	48.5 MB	48.5 MB	-666 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.79 kB	6.79 kB	⚠️ +2 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	N/A	N/A
4952ddcd88e7..167a.js gzip	7.81 kB	N/A	N/A
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..2641f57f9.js	N/A	14.9 kB	N/A
16b1a7225520..57f9.js gzip	N/A	5.38 kB	N/A
4952ddcd88e7..0fb1924cf.js	N/A	21.7 kB	N/A
4952ddcd88e7..24cf.js gzip	N/A	7.77 kB	N/A
de003c3a9d30..aab6ec1a2.js	N/A	28.6 kB	N/A
de003c3a9d30..c1a2.js gzip	N/A	10.8 kB	N/A
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.52 kB	6.52 kB	⚠️ +2 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..3e.module.js	N/A	10.8 kB	N/A
16b1a7225520..dule.js gzip	N/A	4.05 kB	N/A
de003c3a9d30..e6.module.js	N/A	34.8 kB	N/A
de003c3a9d30..dule.js gzip	N/A	12.9 kB	N/A
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.js	1.81 kB	1.63 kB	-184 B
_app.js gzip	873 B	786 B	-87 B
_error.js	12 kB	12.2 kB	⚠️ +183 B
_error.js gzip	4.73 kB	4.78 kB	⚠️ +46 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	⚠️ +1 B
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	⚠️ +2 B
link.js gzip	3.5 kB	3.5 kB	⚠️ +2 B
routerDirect.js	408 B	411 B	⚠️ +3 B
routerDirect.js gzip	281 B	283 B	⚠️ +2 B
withRouter.js	419 B	421 B	⚠️ +2 B
withRouter.js gzip	280 B	282 B	⚠️ +2 B
Overall change	35.8 kB	35.9 kB	⚠️ +6 B

Client Pages Modern Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.module.js	1.7 kB	1.54 kB	-160 B
_app.module.js gzip	832 B	754 B	-78 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	794 B	⚠️ +1 B
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	⚠️ +2 B
link.module.js gzip	3.68 kB	3.68 kB	⚠️ +1 B
routerDirect.module.js	394 B	396 B	⚠️ +2 B
routerDirect..dule.js gzip	281 B	283 B	⚠️ +2 B
withRouter.module.js	404 B	407 B	⚠️ +3 B
withRouter.m..dule.js gzip	278 B	281 B	⚠️ +3 B
Overall change	36.1 kB	35.9 kB	-153 B

Client Build Manifests Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_buildManifest.js	81 B	244 B	⚠️ +163 B
_buildManifest.js gzip	61 B	199 B	⚠️ +138 B
_buildManifest.module.js	81 B	251 B	⚠️ +170 B
_buildManife..dule.js gzip	61 B	209 B	⚠️ +148 B
Overall change	162 B	495 B	⚠️ +333 B

Rendered Page Sizes Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	4.14 kB	⚠️ +474 B
link.html gzip	954 B	1.02 kB	⚠️ +71 B
withRouter.html	3.67 kB	4.14 kB	⚠️ +474 B
withRouter.html gzip	941 B	1.01 kB	⚠️ +73 B
Overall change	10.9 kB	11.9 kB	⚠️ +948 B

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[12],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1772,4 +1772,4 @@ exports["default"] = PageLoader;
 
 /***/ })
 
-},[["BMP1",0,1,2,3]]]);
\ No newline at end of file
+},[["BMP1",0,1,2,3,4]]]);
\ No newline at end of file

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1597,4 +1597,4 @@ exports.default = PageLoader;
 
 /***/ })
 
-},[["BMP1",0,1,2]]]);
\ No newline at end of file
+},[["BMP1",0,1,2,3]]]);
\ No newline at end of file

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {
@@ -31,19 +31,14 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
 
-var _propTypes = _interopRequireDefault(__webpack_require__("17x9"));
-
 var _utils = __webpack_require__("g/15");
 
 exports.AppInitialProps = _utils.AppInitialProps;
-
-var _router = __webpack_require__("nOHt");
 /**
 * `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
 * This allows for keeping state between navigation, custom error handling, injecting additional data.
 */
 
-
 function appGetInitialProps(_x) {
   return _appGetInitialProps.apply(this, arguments);
 }
@@ -89,17 +84,10 @@ function (_react$default$Compon) {
   }
 
   _createClass(App, [{
-    key: "getChildContext",
-    value: function getChildContext() {
-      return {
-        router: (0, _router.makePublicRouterInstance)(this.props.router)
-      };
-    } // Kept here for backwards compatibility.
+    key: "componentDidCatch",
+    // Kept here for backwards compatibility.
     // When someone ended App they could call `super.componentDidCatch`.
     // @deprecated This method is no longer needed. Errors are caught at the top level
-
-  }, {
-    key: "componentDidCatch",
     value: function componentDidCatch(error, _errorInfo) {
       throw error;
     }
@@ -121,9 +109,6 @@ function (_react$default$Compon) {
 }(_react["default"].Component);
 
 exports["default"] = App;
-App.childContextTypes = {
-  router: _propTypes["default"].object
-};
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
 var warnContainer;

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
@@ -393,6 +393,15 @@ module.exports = function (NAME) {
 
 /***/ }),
 
+/***/ "9BDd":
+/***/ (function(module, exports, __webpack_require__) {
+
+__webpack_require__("GvbO");
+module.exports = __webpack_require__("WEpk").Array.isArray;
+
+
+/***/ }),
+
 /***/ "B9jh":
 /***/ (function(module, exports, __webpack_require__) {
 
@@ -466,6 +475,17 @@ exports.HeadManagerContext = React.createContext(null);
 
 /***/ }),
 
+/***/ "GvbO":
+/***/ (function(module, exports, __webpack_require__) {
+
+// 22.1.2.2 / 15.4.3.2 Array.isArray(arg)
+var $export = __webpack_require__("Y7ZC");
+
+$export($export.S, 'Array', { isArray: __webpack_require__("kAMH") });
+
+
+/***/ }),
+
 /***/ "IP1Z":
 /***/ (function(module, exports, __webpack_require__) {
 
@@ -1051,6 +1071,13 @@ module.exports = function (it, TYPE) {
 
 /***/ }),
 
+/***/ "p0XB":
+/***/ (function(module, exports, __webpack_require__) {
+
+module.exports = __webpack_require__("9BDd");
+
+/***/ }),
+
 /***/ "raTm":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -828,4 +828,4 @@ module.exports = function (original, length) {
 
 /***/ })
 
-},[["V8Sf",0,1,2,3]]]);
\ No newline at end of file
+},[["V8Sf",0,1,2,3,4]]]);
\ No newline at end of file

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
@@ -40,4 +40,4 @@ routerDirect.getInitialProps = function () {
 
 /***/ })
 
-},[["LtRI",0,1,2,3]]]);
\ No newline at end of file
+},[["LtRI",0,1,2,3,4]]]);
\ No newline at end of file

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -38,4 +38,4 @@ useWithRouter.getInitialProps = function () {
 
 /***/ })
 
-},[["eThv",0,1,2,3]]]);
\ No newline at end of file
+},[["eThv",0,1,2,3,4]]]);
\ No newline at end of file

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -64,19 +64,14 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
 
-var _propTypes = _interopRequireDefault(__webpack_require__("17x9"));
-
 var _utils = __webpack_require__("g/15");
 
 exports.AppInitialProps = _utils.AppInitialProps;
-
-var _router = __webpack_require__("nOHt");
 /**
 * `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
 * This allows for keeping state between navigation, custom error handling, injecting additional data.
 */
 
-
 function appGetInitialProps(_x) {
   return _appGetInitialProps.apply(this, arguments);
 }
@@ -96,15 +91,9 @@ function _appGetInitialProps() {
 }
 
 class App extends _react.default.Component {
-  getChildContext() {
-    return {
-      router: (0, _router.makePublicRouterInstance)(this.props.router)
-    };
-  } // Kept here for backwards compatibility.
+  // Kept here for backwards compatibility.
   // When someone ended App they could call `super.componentDidCatch`.
   // @deprecated This method is no longer needed. Errors are caught at the top level
-
-
   componentDidCatch(error, _errorInfo) {
     throw error;
   }
@@ -124,9 +113,6 @@ class App extends _react.default.Component {
 }
 
 exports.default = App;
-App.childContextTypes = {
-  router: _propTypes.default.object
-};
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
 let warnContainer;

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -876,4 +876,4 @@ module.exports = function (original, length) {
 
 /***/ })
 
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["V8Sf",0,1,2,3]]]);
\ No newline at end of file

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
@@ -38,4 +38,4 @@ routerDirect.getInitialProps = () => ({});
 
 /***/ })
 
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["LtRI",0,1,2,3]]]);
\ No newline at end of file

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -36,4 +36,4 @@ useWithRouter.getInitialProps = () => ({});
 
 /***/ })
 
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eThv",0,1,2,3]]]);
\ No newline at end of file

Diff for _buildManifest.js

@@ -1 +1 @@
-self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file

Diff for _buildManifest.module.js

@@ -1 +1 @@
-self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file

Diff for index.html

@@ -12,11 +12,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,19 +43,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-b96de587806cdb6eac72.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -14,9 +14,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
+        as="script" crossorigin="anonymous" />
+        <link rel="preload" href="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,15 +52,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        async="" crossorigin="anonymous" nomodule=""></script>
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        async="" crossorigin="anonymous" type="module"></script>
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-b96de587806cdb6eac72.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -14,9 +14,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
+        as="script" crossorigin="anonymous" />
+        <link rel="preload" href="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -48,15 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        async="" crossorigin="anonymous" nomodule=""></script>
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        async="" crossorigin="anonymous" type="module"></script>
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-b96de587806cdb6eac72.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
buildDuration	15.6s	14.4s	-1.2s
nodeModulesSize	48.5 MB	48.5 MB	-666 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.79 kB	6.79 kB	⚠️ +2 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	N/A	N/A
4952ddcd88e7..167a.js gzip	7.81 kB	N/A	N/A
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..2641f57f9.js	N/A	14.9 kB	N/A
16b1a7225520..57f9.js gzip	N/A	5.38 kB	N/A
4952ddcd88e7..0fb1924cf.js	N/A	21.7 kB	N/A
4952ddcd88e7..24cf.js gzip	N/A	7.77 kB	N/A
de003c3a9d30..aab6ec1a2.js	N/A	28.6 kB	N/A
de003c3a9d30..c1a2.js gzip	N/A	10.8 kB	N/A
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.52 kB	6.52 kB	⚠️ +2 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..3e.module.js	N/A	10.8 kB	N/A
16b1a7225520..dule.js gzip	N/A	4.05 kB	N/A
de003c3a9d30..e6.module.js	N/A	34.8 kB	N/A
de003c3a9d30..dule.js gzip	N/A	12.9 kB	N/A
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.js	1.81 kB	1.63 kB	-184 B
_app.js gzip	873 B	786 B	-87 B
_error.js	12 kB	12.2 kB	⚠️ +183 B
_error.js gzip	4.73 kB	4.78 kB	⚠️ +46 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	⚠️ +1 B
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	⚠️ +2 B
link.js gzip	3.5 kB	3.5 kB	⚠️ +2 B
routerDirect.js	408 B	411 B	⚠️ +3 B
routerDirect.js gzip	281 B	283 B	⚠️ +2 B
withRouter.js	419 B	421 B	⚠️ +2 B
withRouter.js gzip	280 B	282 B	⚠️ +2 B
Overall change	35.8 kB	35.9 kB	⚠️ +6 B

Client Pages Modern Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.module.js	1.7 kB	1.54 kB	-160 B
_app.module.js gzip	832 B	754 B	-78 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	794 B	⚠️ +1 B
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	⚠️ +2 B
link.module.js gzip	3.68 kB	3.68 kB	⚠️ +1 B
routerDirect.module.js	394 B	396 B	⚠️ +2 B
routerDirect..dule.js gzip	281 B	283 B	⚠️ +2 B
withRouter.module.js	404 B	407 B	⚠️ +3 B
withRouter.m..dule.js gzip	278 B	281 B	⚠️ +3 B
Overall change	36.1 kB	35.9 kB	-153 B

Client Build Manifests Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_buildManifest.js	81 B	244 B	⚠️ +163 B
_buildManifest.js gzip	61 B	199 B	⚠️ +138 B
_buildManifest.module.js	81 B	251 B	⚠️ +170 B
_buildManife..dule.js gzip	61 B	209 B	⚠️ +148 B
Overall change	162 B	495 B	⚠️ +333 B

Serverless bundles Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_error.js	254 kB	229 kB	-24.5 kB
_error.js gzip	68 kB	61.3 kB	-6.71 kB
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	978 B	-1 B
index.js	254 kB	230 kB	-24.5 kB
index.js gzip	68.4 kB	61.6 kB	-6.76 kB
link.js	262 kB	262 kB	⚠️ +219 B
link.js gzip	70.4 kB	70.4 kB	⚠️ +12 B
routerDirect.js	255 kB	255 kB	⚠️ +219 B
routerDirect.js gzip	68.4 kB	68.4 kB	⚠️ +15 B
withRouter.js	255 kB	255 kB	⚠️ +219 B
withRouter.js gzip	68.5 kB	68.5 kB	⚠️ +27 B
Overall change	1.28 MB	1.24 MB	-48.3 kB

Commit: 755b5ca

ijjk · 2019-10-15T16:14:30Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
buildDuration	15.9s	15.6s	-336ms
nodeModulesSize	48.5 MB	48.5 MB	-666 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.79 kB	6.79 kB	⚠️ +2 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	N/A	N/A
4952ddcd88e7..167a.js gzip	7.81 kB	N/A	N/A
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..2641f57f9.js	N/A	14.9 kB	N/A
16b1a7225520..57f9.js gzip	N/A	5.38 kB	N/A
4952ddcd88e7..0fb1924cf.js	N/A	21.7 kB	N/A
4952ddcd88e7..24cf.js gzip	N/A	7.77 kB	N/A
de003c3a9d30..aab6ec1a2.js	N/A	28.6 kB	N/A
de003c3a9d30..c1a2.js gzip	N/A	10.8 kB	N/A
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.52 kB	6.52 kB	⚠️ +2 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..3e.module.js	N/A	10.8 kB	N/A
16b1a7225520..dule.js gzip	N/A	4.05 kB	N/A
de003c3a9d30..e6.module.js	N/A	34.8 kB	N/A
de003c3a9d30..dule.js gzip	N/A	12.9 kB	N/A
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.js	1.81 kB	1.63 kB	-184 B
_app.js gzip	873 B	786 B	-87 B
_error.js	12 kB	12.2 kB	⚠️ +183 B
_error.js gzip	4.73 kB	4.78 kB	⚠️ +46 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	⚠️ +1 B
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	⚠️ +2 B
link.js gzip	3.5 kB	3.5 kB	⚠️ +2 B
routerDirect.js	408 B	411 B	⚠️ +3 B
routerDirect.js gzip	281 B	283 B	⚠️ +2 B
withRouter.js	419 B	421 B	⚠️ +2 B
withRouter.js gzip	280 B	282 B	⚠️ +2 B
Overall change	35.8 kB	35.9 kB	⚠️ +6 B

Client Pages Modern Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.module.js	1.7 kB	1.54 kB	-160 B
_app.module.js gzip	832 B	754 B	-78 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	794 B	⚠️ +1 B
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	⚠️ +2 B
link.module.js gzip	3.68 kB	3.68 kB	⚠️ +1 B
routerDirect.module.js	394 B	396 B	⚠️ +2 B
routerDirect..dule.js gzip	281 B	283 B	⚠️ +2 B
withRouter.module.js	404 B	407 B	⚠️ +3 B
withRouter.m..dule.js gzip	278 B	281 B	⚠️ +3 B
Overall change	36.1 kB	35.9 kB	-153 B

Client Build Manifests Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_buildManifest.js	81 B	244 B	⚠️ +163 B
_buildManifest.js gzip	61 B	199 B	⚠️ +138 B
_buildManifest.module.js	81 B	251 B	⚠️ +170 B
_buildManife..dule.js gzip	61 B	209 B	⚠️ +148 B
Overall change	162 B	495 B	⚠️ +333 B

Rendered Page Sizes Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	4.14 kB	⚠️ +474 B
link.html gzip	954 B	1.02 kB	⚠️ +71 B
withRouter.html	3.67 kB	4.14 kB	⚠️ +474 B
withRouter.html gzip	941 B	1.01 kB	⚠️ +73 B
Overall change	10.9 kB	11.9 kB	⚠️ +948 B

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[12],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1772,4 +1772,4 @@ exports["default"] = PageLoader;
 
 /***/ })
 
-},[["BMP1",0,1,2,3]]]);
\ No newline at end of file
+},[["BMP1",0,1,2,3,4]]]);
\ No newline at end of file

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1597,4 +1597,4 @@ exports.default = PageLoader;
 
 /***/ })
 
-},[["BMP1",0,1,2]]]);
\ No newline at end of file
+},[["BMP1",0,1,2,3]]]);
\ No newline at end of file

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {
@@ -31,19 +31,14 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
 
-var _propTypes = _interopRequireDefault(__webpack_require__("17x9"));
-
 var _utils = __webpack_require__("g/15");
 
 exports.AppInitialProps = _utils.AppInitialProps;
-
-var _router = __webpack_require__("nOHt");
 /**
 * `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
 * This allows for keeping state between navigation, custom error handling, injecting additional data.
 */
 
-
 function appGetInitialProps(_x) {
   return _appGetInitialProps.apply(this, arguments);
 }
@@ -89,17 +84,10 @@ function (_react$default$Compon) {
   }
 
   _createClass(App, [{
-    key: "getChildContext",
-    value: function getChildContext() {
-      return {
-        router: (0, _router.makePublicRouterInstance)(this.props.router)
-      };
-    } // Kept here for backwards compatibility.
+    key: "componentDidCatch",
+    // Kept here for backwards compatibility.
     // When someone ended App they could call `super.componentDidCatch`.
     // @deprecated This method is no longer needed. Errors are caught at the top level
-
-  }, {
-    key: "componentDidCatch",
     value: function componentDidCatch(error, _errorInfo) {
       throw error;
     }
@@ -121,9 +109,6 @@ function (_react$default$Compon) {
 }(_react["default"].Component);
 
 exports["default"] = App;
-App.childContextTypes = {
-  router: _propTypes["default"].object
-};
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
 var warnContainer;

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
@@ -393,6 +393,15 @@ module.exports = function (NAME) {
 
 /***/ }),
 
+/***/ "9BDd":
+/***/ (function(module, exports, __webpack_require__) {
+
+__webpack_require__("GvbO");
+module.exports = __webpack_require__("WEpk").Array.isArray;
+
+
+/***/ }),
+
 /***/ "B9jh":
 /***/ (function(module, exports, __webpack_require__) {
 
@@ -466,6 +475,17 @@ exports.HeadManagerContext = React.createContext(null);
 
 /***/ }),
 
+/***/ "GvbO":
+/***/ (function(module, exports, __webpack_require__) {
+
+// 22.1.2.2 / 15.4.3.2 Array.isArray(arg)
+var $export = __webpack_require__("Y7ZC");
+
+$export($export.S, 'Array', { isArray: __webpack_require__("kAMH") });
+
+
+/***/ }),
+
 /***/ "IP1Z":
 /***/ (function(module, exports, __webpack_require__) {
 
@@ -1051,6 +1071,13 @@ module.exports = function (it, TYPE) {
 
 /***/ }),
 
+/***/ "p0XB":
+/***/ (function(module, exports, __webpack_require__) {
+
+module.exports = __webpack_require__("9BDd");
+
+/***/ }),
+
 /***/ "raTm":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -828,4 +828,4 @@ module.exports = function (original, length) {
 
 /***/ })
 
-},[["V8Sf",0,1,2,3]]]);
\ No newline at end of file
+},[["V8Sf",0,1,2,3,4]]]);
\ No newline at end of file

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
@@ -40,4 +40,4 @@ routerDirect.getInitialProps = function () {
 
 /***/ })
 
-},[["LtRI",0,1,2,3]]]);
\ No newline at end of file
+},[["LtRI",0,1,2,3,4]]]);
\ No newline at end of file

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -38,4 +38,4 @@ useWithRouter.getInitialProps = function () {
 
 /***/ })
 
-},[["eThv",0,1,2,3]]]);
\ No newline at end of file
+},[["eThv",0,1,2,3,4]]]);
\ No newline at end of file

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -64,19 +64,14 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
 
-var _propTypes = _interopRequireDefault(__webpack_require__("17x9"));
-
 var _utils = __webpack_require__("g/15");
 
 exports.AppInitialProps = _utils.AppInitialProps;
-
-var _router = __webpack_require__("nOHt");
 /**
 * `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
 * This allows for keeping state between navigation, custom error handling, injecting additional data.
 */
 
-
 function appGetInitialProps(_x) {
   return _appGetInitialProps.apply(this, arguments);
 }
@@ -96,15 +91,9 @@ function _appGetInitialProps() {
 }
 
 class App extends _react.default.Component {
-  getChildContext() {
-    return {
-      router: (0, _router.makePublicRouterInstance)(this.props.router)
-    };
-  } // Kept here for backwards compatibility.
+  // Kept here for backwards compatibility.
   // When someone ended App they could call `super.componentDidCatch`.
   // @deprecated This method is no longer needed. Errors are caught at the top level
-
-
   componentDidCatch(error, _errorInfo) {
     throw error;
   }
@@ -124,9 +113,6 @@ class App extends _react.default.Component {
 }
 
 exports.default = App;
-App.childContextTypes = {
-  router: _propTypes.default.object
-};
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
 let warnContainer;

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -876,4 +876,4 @@ module.exports = function (original, length) {
 
 /***/ })
 
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["V8Sf",0,1,2,3]]]);
\ No newline at end of file

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
@@ -38,4 +38,4 @@ routerDirect.getInitialProps = () => ({});
 
 /***/ })
 
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["LtRI",0,1,2,3]]]);
\ No newline at end of file

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -36,4 +36,4 @@ useWithRouter.getInitialProps = () => ({});
 
 /***/ })
 
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eThv",0,1,2,3]]]);
\ No newline at end of file

Diff for _buildManifest.js

@@ -1 +1 @@
-self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file

Diff for _buildManifest.module.js

@@ -1 +1 @@
-self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file

Diff for index.html

@@ -12,11 +12,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,19 +43,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-b96de587806cdb6eac72.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -14,9 +14,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
+        as="script" crossorigin="anonymous" />
+        <link rel="preload" href="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,15 +52,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        async="" crossorigin="anonymous" nomodule=""></script>
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        async="" crossorigin="anonymous" type="module"></script>
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-b96de587806cdb6eac72.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -14,9 +14,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
+        as="script" crossorigin="anonymous" />
+        <link rel="preload" href="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -48,15 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        async="" crossorigin="anonymous" nomodule=""></script>
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        async="" crossorigin="anonymous" type="module"></script>
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-b96de587806cdb6eac72.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-cc24768465ac64592ef4.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
buildDuration	16.1s	16s	-31ms
nodeModulesSize	48.5 MB	48.5 MB	-666 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.79 kB	6.79 kB	⚠️ +2 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	N/A	N/A
4952ddcd88e7..167a.js gzip	7.81 kB	N/A	N/A
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..2641f57f9.js	N/A	14.9 kB	N/A
16b1a7225520..57f9.js gzip	N/A	5.38 kB	N/A
4952ddcd88e7..0fb1924cf.js	N/A	21.7 kB	N/A
4952ddcd88e7..24cf.js gzip	N/A	7.77 kB	N/A
de003c3a9d30..aab6ec1a2.js	N/A	28.6 kB	N/A
de003c3a9d30..c1a2.js gzip	N/A	10.8 kB	N/A
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.52 kB	6.52 kB	⚠️ +2 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..3e.module.js	N/A	10.8 kB	N/A
16b1a7225520..dule.js gzip	N/A	4.05 kB	N/A
de003c3a9d30..e6.module.js	N/A	34.8 kB	N/A
de003c3a9d30..dule.js gzip	N/A	12.9 kB	N/A
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.js	1.81 kB	1.63 kB	-184 B
_app.js gzip	873 B	786 B	-87 B
_error.js	12 kB	12.2 kB	⚠️ +183 B
_error.js gzip	4.73 kB	4.78 kB	⚠️ +46 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	⚠️ +1 B
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	⚠️ +2 B
link.js gzip	3.5 kB	3.5 kB	⚠️ +2 B
routerDirect.js	408 B	411 B	⚠️ +3 B
routerDirect.js gzip	281 B	283 B	⚠️ +2 B
withRouter.js	419 B	421 B	⚠️ +2 B
withRouter.js gzip	280 B	282 B	⚠️ +2 B
Overall change	35.8 kB	35.9 kB	⚠️ +6 B

Client Pages Modern Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_app.module.js	1.7 kB	1.54 kB	-160 B
_app.module.js gzip	832 B	754 B	-78 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	794 B	⚠️ +1 B
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	⚠️ +2 B
link.module.js gzip	3.68 kB	3.68 kB	⚠️ +1 B
routerDirect.module.js	394 B	396 B	⚠️ +2 B
routerDirect..dule.js gzip	281 B	283 B	⚠️ +2 B
withRouter.module.js	404 B	407 B	⚠️ +3 B
withRouter.m..dule.js gzip	278 B	281 B	⚠️ +3 B
Overall change	36.1 kB	35.9 kB	-153 B

Client Build Manifests Overall increase ⚠️

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_buildManifest.js	81 B	244 B	⚠️ +163 B
_buildManifest.js gzip	61 B	199 B	⚠️ +138 B
_buildManifest.module.js	81 B	251 B	⚠️ +170 B
_buildManife..dule.js gzip	61 B	209 B	⚠️ +148 B
Overall change	162 B	495 B	⚠️ +333 B

Serverless bundles Overall decrease ✓

	zeit/next.js canary	devknoll/next.js remove-app-context	Change
_error.js	254 kB	229 kB	-24.5 kB
_error.js gzip	68 kB	61.3 kB	-6.71 kB
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	978 B	-1 B
index.js	254 kB	230 kB	-24.5 kB
index.js gzip	68.4 kB	61.6 kB	-6.76 kB
link.js	262 kB	262 kB	⚠️ +219 B
link.js gzip	70.4 kB	70.4 kB	⚠️ +12 B
routerDirect.js	255 kB	255 kB	⚠️ +219 B
routerDirect.js gzip	68.4 kB	68.4 kB	⚠️ +15 B
withRouter.js	255 kB	255 kB	⚠️ +219 B
withRouter.js gzip	68.5 kB	68.5 kB	⚠️ +27 B
Overall change	1.28 MB	1.24 MB	-48.3 kB

Commit: dc89d24

timneutkens · 2019-10-16T09:40:07Z

Thanks @devknoll!

devknoll requested review from ijjk, lfades, Timer and timneutkens as code owners October 15, 2019 15:54

Update legacy _app context

dc89d24

timneutkens approved these changes Oct 16, 2019

View reviewed changes

timneutkens merged commit beed775 into vercel:canary Oct 16, 2019

timneutkens mentioned this pull request Oct 16, 2019

Convert wrapper class to function component #9095

Merged

devknoll mentioned this pull request Oct 17, 2019

withRouter hoc, useRouter hook not working anymore after canary upgrade #9105

Closed

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update legacy _app context #9083

Update legacy _app context #9083

devknoll commented Oct 15, 2019

ijjk commented Oct 15, 2019

Diffs

ijjk commented Oct 15, 2019

Diffs

timneutkens commented Oct 16, 2019

Update legacy _app context #9083

Update legacy _app context #9083

Conversation

devknoll commented Oct 15, 2019

ijjk commented Oct 15, 2019

Stats from current PR

Diffs

ijjk commented Oct 15, 2019

Stats from current PR

Diffs

timneutkens commented Oct 16, 2019