-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace rustls-native-certs
with rustls-platform-verifier
#24656
Conversation
Co-Authored-By: Bennet <bennet@zed.dev>
On it - will keep an eye out for the CI run + share logs back if any issues. |
Thanks so much @elithrar! I believe you said you're on macOS, these are the artifacts that were generated: aarch64: https://github.com/zed-industries/zed/actions/runs/13266472467/artifacts/2572655570 |
Still seeing peer certificate errors in the log (and thus a failure to sign in / use native network-dependent features):
... and the expected logspam:
|
If we can get it to output the root CAs it's parsing/loading it may be helpful to see what's not being caught - although |
@elithrar Does your environment have an variables that are used in CA certificate selection that we might also need to pass on? One thing to note in this space is that we're trying hard not to accidentally depend on openssl. I checked this PR and it's good: |
On macOS > security find-certificate -c "Cloudflare Corporate Zero Trust"
keychain: "/Library/Keychains/System.keychain"
version: 256
class: 0x80001000
attributes:
"alis"<blob>="Cloudflare Corporate Zero Trust"
... It's not clear to me why it's not loading that however — other native macOS apps work fine (as expected). |
In an effort to squash bugs like: #19620, and improve confidence on PRs like: #24656, I created this little test script using `mitmproxy` to simulate the situation. Unfortunately, I don't see any issues with our current usage of the local certificate store using this script. But I'd like to have it as a base to build off of. Release Notes: - N/A
FYI this appears to have broken the windows release build
Probably related to this issue: aws/aws-lc-rs#691 |
…zed-industries#24656)" This reverts commit 2b7d372.
…zed-industries#24656)" This reverts commit 2b7d372.
…zed-industries#24656)" This reverts commit 2b7d372. # Conflicts: # Cargo.lock
…zed-industries#24656)" This reverts commit 2b7d372. # Conflicts: # Cargo.lock
…zed-industries#24656)" This reverts commit 2b7d372. # Conflicts: # Cargo.lock
…zed-industries#24656)" This reverts commit 2b7d372. # Conflicts: # Cargo.lock
closes #19620.
I am not 100% sure on how to test this though. @elithrar: would you mind giving this branch a shot and seeing if it works for you? I kicked off bundling for this pull request and you should be able to download a DMG from the CI artifacts as soon as it's done building.
Release Notes: