Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rustls-native-certs with rustls-platform-verifier #24656

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

as-cii
Copy link
Member

@as-cii as-cii commented Feb 11, 2025

closes #19620.

I am not 100% sure on how to test this though. @elithrar: would you mind giving this branch a shot and seeing if it works for you? I kicked off bundling for this pull request and you should be able to download a DMG from the CI artifacts as soon as it's done building.

Release Notes:

  • Fixed a bug that caused OS-level CA certificate bundles to not be respected.

Co-Authored-By: Bennet <bennet@zed.dev>
@as-cii as-cii added the run-bundling Configures PR to run the bundle step label Feb 11, 2025
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 11, 2025
@elithrar
Copy link

On it - will keep an eye out for the CI run + share logs back if any issues.

@as-cii
Copy link
Member Author

as-cii commented Feb 11, 2025

Thanks so much @elithrar! I believe you said you're on macOS, these are the artifacts that were generated:

aarch64: https://github.com/zed-industries/zed/actions/runs/13266472467/artifacts/2572655570
x86_64: https://github.com/zed-industries/zed/actions/runs/13266472467/artifacts/2572655966

@elithrar
Copy link

Still seeing peer certificate errors in the log (and thus a failure to sign in / use native network-dependent features):

Caused by:
    0: error sending request for url (https://api.github.com/repos/zed-industries/copilot/releases/tags/v0.7.0)
    1: client error (Connect)
    2: invalid peer certificate: BadSignature
2025-02-11T11:26:41.238868-05:00 [INFO] set environment variables from shell:/bin/zsh, path:/Users/matt/.sst/bin:/Users/matt/.rbenv/shims:/Users/matt/.nvm/versions/node/v21.5.0/bin:/Users/matt/repos/google-cloud-sdk/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/matt/repos/go/bin:/Users/matt/.cargo/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/matt/.local/bin
2025-02-11T11:26:53.798608-05:00 [INFO] set status on client 253412: Reauthenticating
2025-02-11T11:26:53.811664-05:00 [INFO] set status on client 253412: Reconnecting
2025-02-11T11:26:53.871206-05:00 [INFO] set status on client 253412: ConnectionError
2025-02-11T11:26:53.871445-05:00 [ERROR] error sending request for url (https://zed.dev/rpc)

Caused by:
    0: error sending request for url (https://zed.dev/rpc)
    1: client error (Connect)
    2: invalid peer certificate: BadSignature

... and the expected logspam:

2025-02-11T11:16:08.751689-05:00 [INFO] set status on client 253412: Reauthenticating
2025-02-11T11:16:08.752258-05:00 [INFO] set status on client 253412: Reconnecting
2025-02-11T11:16:08.866154-05:00 [INFO] set status on client 253412: ConnectionError
2025-02-11T11:16:08.866458-05:00 [ERROR] failed to connect error sending request for url (https://zed.dev/rpc?preview=1)
2025-02-11T11:16:08.866668-05:00 [INFO] set status on client 253412: ReconnectionError { next_reconnection: Instant { tv_sec: 4895, tv_nsec: 421187333 } }
2025-02-11T11:16:18.902-05:00 [INFO] set status on client 253412: Reauthenticating
2025-02-11T11:16:18.902933-05:00 [INFO] set status on client 253412: Reconnecting
2025-02-11T11:16:18.966199-05:00 [INFO] set status on client 253412: ConnectionError
2025-02-11T11:16:18.966561-05:00 [ERROR] failed to connect error sending request for url (https://zed.dev/rpc?preview=1)
2025-02-11T11:16:18.966914-05:00 [INFO] set status on client 253412: ReconnectionError { next_reconnection: Instant { tv_sec: 4905, tv_nsec: 521544458 } }
2025-02-11T11:16:29.013301-05:00 [INFO] set status on client 253412: Reauthenticating
2025-02-11T11:16:29.013906-05:00 [INFO] set status on client 253412: Reconnecting
2025-02-11T11:16:29.099209-05:00 [INFO] set status on client 253412: ConnectionError
2025-02-11T11:16:29.09963-05:00 [ERROR] failed to connect error sending request for url (https://zed.dev/rpc?preview=1)
2025-02-11T11:16:29.099994-05:00 [INFO] set status on client 253412: ReconnectionError { next_reconnection: Instant { tv_sec: 4915, tv_nsec: 654736875 } }

@elithrar
Copy link

If we can get it to output the root CAs it's parsing/loading it may be helpful to see what's not being caught - although ClientConfig doesn't seem to expose a simple way to dump that?

@ConradIrwin
Copy link
Member

@elithrar Does your environment have an variables that are used in CA certificate selection that we might also need to pass on?

One thing to note in this space is that we're trying hard not to accidentally depend on openssl. I checked this PR and it's good: cargo tree --target x86_64-unknown-linux-gnu | grep openssl-sys returns nothing as it should. (just openssl-probe to read the root CA stores).

@elithrar
Copy link

On macOS with_platform_verifier should be using the OS-specific Security.framework and the system keychain:

> security find-certificate -c "Cloudflare Corporate Zero Trust"
keychain: "/Library/Keychains/System.keychain"
version: 256
class: 0x80001000
attributes:
    "alis"<blob>="Cloudflare Corporate Zero Trust"
...

It's not clear to me why it's not loading that however — other native macOS apps work fine (as expected).

mikayla-maki added a commit that referenced this pull request Feb 11, 2025
In an effort to squash bugs like:
#19620, and improve
confidence on PRs like:
#24656, I created this little
test script using `mitmproxy` to simulate the situation.

Unfortunately, I don't see any issues with our current usage of the
local certificate store using this script. But I'd like to have it as a
base to build off of.

Release Notes:

- N/A
@mikayla-maki mikayla-maki merged commit 2b7d372 into main Feb 12, 2025
13 checks passed
@mikayla-maki mikayla-maki deleted the rustls_platform_verifier branch February 12, 2025 15:32
@ggoodale
Copy link

ggoodale commented Feb 14, 2025

FYI this appears to have broken the windows release build

   Compiling rustls-platform-verifier v0.5.0
error: linking with `link.exe` failed: exit code: 1120
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x64\\link.exe" "/DEF:C:\\Users\\ggood\\AppData\\Local\\Temp\\rustcXtahw6\\lib.def" "/NOLOGO" "C:\\Users\\ggood\\AppData\\Local\\Temp\\rustcXtahw6\\symbols.o" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\rustls_platform_verifier-358106cb4cc5cb2d.rustls_platform_verifier.6db4467dec9eae50-cgu.0.rcgu.o" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\rustls_platform_verifier-358106cb4cc5cb2d.68ipgtbx9cosg8j69pqiqbwi9.rcgu.o" "/LIBPATH:C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps" "/LIBPATH:C:\\Users\\ggood\\Projects\\zed\\target\\release\\build\\aws-lc-sys-d9dfb6deb25ed5d7\\out\\build\\artifacts" "/LIBPATH:C:\\Users\\ggood\\Projects\\zed\\target\\release\\build\\ring-7de6f82dae0ac5a6\\out" "/LIBPATH:C:\\Users\\ggood\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\windows_x86_64_msvc-0.52.6\\lib" "/LIBPATH:C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libwindows_sys-c13ead6c2db31e43.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libwindows_targets-dd5c343aa4c03936.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libonce_cell-279f04b7014fa88b.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\librustls-06460a92af4f2a4c.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libsubtle-04cc0634aed40b0e.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libwebpki-5521804b2b1df925.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libaws_lc_rs-f684d3ec7619318e.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libaws_lc_sys-1785ff08eb29ae8f.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libring-dd91240241496fc8.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libgetrandom-274c13054a6014ce.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libspin-416544142fe120bc.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\liblock_api-c4625aa614c21fa7.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libscopeguard-fbe94bb28876ffc3.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libuntrusted-480f9b07eaf8feb0.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libcfg_if-2d6e24921ff68462.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libzeroize-ce9f7ed2edabce28.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\librustls_pki_types-2bacb3eb0727c7d8.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\liblog-9e6ce09ef8a39bd1.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libvalue_bag-4ce1868079ae2b8f.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libvalue_bag_serde1-c47bd1ef5e6c6812.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libserde_fmt-9637f976f46bde11.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\liberased_serde-a1963408e1ee3e8b.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libtypeid-5e6edca436fb012c.rlib" "C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\libserde-1a2a3f8525ddc56c.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-759718a9bb18a123.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-7da375a7ca1e9a5e.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-13c5a35fb3626718.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_detect-67d9d7b318bd750d.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-1128f34f910afc3a.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-ec2cabfc22cdef7d.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-93dda7487230aeda.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-814df84e64e9c749.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-bcbe36736b9f0af2.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-d08e4e7d05aff086.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-89ef43c30f9b928e.rlib" "C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-1426abde5263ac46.rlib" "windows.0.52.0.lib" "bcrypt.lib" "advapi32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "kernel32.lib" "kernel32.lib" "/defaultlib:libcmt" "/NXCOMPAT" "/LIBPATH:C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\rustls_platform_verifier-358106cb4cc5cb2d.dll" "/OPT:REF,ICF" "/DLL" "/IMPLIB:C:\\Users\\ggood\\Projects\\zed\\target\\release\\deps\\rustls_platform_verifier-358106cb4cc5cb2d.dll.lib" "/DEBUG" "/PDBALTPATH:%_PDB%" "/NATVIS:C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:C:\\Users\\ggood\\.rustup\\toolchains\\1.81-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libstd.natvis"
  = note:    Creating library C:\Users\ggood\Projects\zed\target\release\deps\rustls_platform_verifier-358106cb4cc5cb2d.dll.lib and object C:\Users\ggood\Projects\zed\target\release\deps\rustls_platform_verifier-358106cb4cc5cb2d.dll.exp
          LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library
          LINK : warning LNK4217: symbol 'free' defined in 'libucrt.lib(free.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj)' in function 'rand_thread_state_free'
          LINK : warning LNK4286: symbol 'free' defined in 'libucrt.lib(free.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(mem.obj)'
          LINK : warning LNK4286: symbol 'free' defined in 'libucrt.lib(free.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj)'
          LINK : warning LNK4286: symbol 'free' defined in 'libucrt.lib(free.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(thread_win.obj)'
          LINK : warning LNK4217: symbol 'malloc' defined in 'libucrt.lib(malloc.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj)' in function 'aws_lc_0_25_0_RAND_bytes_with_additional_data'
          LINK : warning LNK4286: symbol 'malloc' defined in 'libucrt.lib(malloc.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(mem.obj)'
          LINK : warning LNK4286: symbol 'malloc' defined in 'libucrt.lib(malloc.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj)'
          LINK : warning LNK4286: symbol 'malloc' defined in 'libucrt.lib(malloc.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(thread_win.obj)'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(refcount_win.obj)'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(ex_data.obj)'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(windows.obj)'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(obj.obj)'
          LINK : warning LNK4217: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj)' in function 'aws_lc_0_25_0_CRYPTO_gcm128_aad'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(crypto.obj)'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj)'
          LINK : warning LNK4286: symbol 'abort' defined in 'libucrt.lib(abort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(thread_win.obj)'
          LINK : warning LNK4217: symbol '__acrt_iob_func' defined in 'libucrt.lib(_file.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj)' in function 'aws_lc_0_25_0_handle_cpu_env'
          LINK : warning LNK4217: symbol 'fflush' defined in 'libucrt.lib(fflush.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj)' in function 'check_test'
          LINK : warning LNK4286: symbol 'fflush' defined in 'libucrt.lib(fflush.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj)'
          LINK : warning LNK4217: symbol '__stdio_common_vfprintf' defined in 'libucrt.lib(output.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj)' in function 'fprintf'
          LINK : warning LNK4217: symbol '_errno' defined in 'libucrt.lib(errno.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(mem.obj)' in function 'aws_lc_0_25_0_OPENSSL_vasprintf_internal'
          LINK : warning LNK4286: symbol '_errno' defined in 'libucrt.lib(errno.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj)'
          LINK : warning LNK4286: symbol '_errno' defined in 'libucrt.lib(errno.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj)'
          LINK : warning LNK4217: symbol '__stdio_common_vsprintf' defined in 'libucrt.lib(output.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(mem.obj)' in function 'aws_lc_0_25_0_BIO_vsnprintf'
          LINK : warning LNK4286: symbol '__stdio_common_vsprintf' defined in 'libucrt.lib(output.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(cbs.obj)'
          LINK : warning LNK4286: symbol '__stdio_common_vsprintf' defined in 'libucrt.lib(output.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj)'
          LINK : warning LNK4286: symbol '__stdio_common_vsprintf' defined in 'libucrt.lib(output.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(printf.obj)'
          LINK : warning LNK4217: symbol 'qsort' defined in 'libucrt.lib(qsort.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(cbb.obj)' in function 'aws_lc_0_25_0_CBB_flush_asn1_set_of'
          LINK : warning LNK4217: symbol 'fclose' defined in 'libucrt.lib(fclose.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj)' in function 'file_free'
          LINK : warning LNK4217: symbol '_fileno' defined in 'libucrt.lib(fileno.obj)' is imported by 'libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj)' in function 'file_ctrl'
          libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj) : error LNK2019: unresolved external symbol __imp_strtol referenced in function pkey_rsa_ctrl_str
          libaws_lc_sys-1785ff08eb29ae8f.rlib(p_dh.obj) : error LNK2001: unresolved external symbol __imp_strtol
          libaws_lc_sys-1785ff08eb29ae8f.rlib(p_dsa.obj) : error LNK2001: unresolved external symbol __imp_strtol
          libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj) : error LNK2019: unresolved external symbol __imp_getenv referenced in function aws_lc_0_25_0_OPENSSL_cpuid_setup
          libaws_lc_sys-1785ff08eb29ae8f.rlib(bcm.obj) : error LNK2019: unresolved external symbol __imp___stdio_common_vsscanf referenced in function sscanf
          libaws_lc_sys-1785ff08eb29ae8f.rlib(mem.obj) : error LNK2019: unresolved external symbol __imp_realloc referenced in function aws_lc_0_25_0_OPENSSL_vasprintf_internal
          libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj) : error LNK2019: unresolved external symbol __imp_fputs referenced in function print_errors_to_file
          libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj) : error LNK2019: unresolved external symbol __imp_bsearch referenced in function err_string_lookup
          libaws_lc_sys-1785ff08eb29ae8f.rlib(obj.obj) : error LNK2001: unresolved external symbol __imp_bsearch
          libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj) : error LNK2019: unresolved external symbol __imp_strerror referenced in function err_reason_error_string
          libaws_lc_sys-1785ff08eb29ae8f.rlib(err.obj) : error LNK2019: unresolved external symbol __imp_strdup referenced in function aws_lc_0_25_0_ERR_set_error_data
          OLDNAMES.lib(strdup.obi) : error LNK2001: unresolved external symbol __imp_strdup
          libaws_lc_sys-1785ff08eb29ae8f.rlib(stack.obj) : error LNK2019: unresolved external symbol __imp_qsort_s referenced in function aws_lc_0_25_0_OPENSSL_sk_sort
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_feof referenced in function file_ctrl
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_ferror referenced in function file_read
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_fgets referenced in function file_gets
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_fopen referenced in function file_ctrl
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_fread referenced in function file_read
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_fseek referenced in function file_ctrl
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_ftell referenced in function file_ctrl
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp_fwrite referenced in function file_write
          libaws_lc_sys-1785ff08eb29ae8f.rlib(file.obj) : error LNK2019: unresolved external symbol __imp__setmode referenced in function file_ctrl
          OLDNAMES.lib(strdup.obi) : error LNK2001: unresolved external symbol __imp__strdup
          C:\Users\ggood\Projects\zed\target\release\deps\rustls_platform_verifier-358106cb4cc5cb2d.dll : fatal error LNK1120: 19 unresolved externals


error: could not compile `rustls-platform-verifier` (lib) due to 1 previous error

Probably related to this issue: aws/aws-lc-rs#691

shenjackyuanjie added a commit to shenjackyuanjie/zed that referenced this pull request Feb 14, 2025
chapel added a commit to chapel/zed that referenced this pull request Feb 16, 2025
shenjackyuanjie added a commit to shenjackyuanjie/zed that referenced this pull request Feb 17, 2025
shenjackyuanjie added a commit to shenjackyuanjie/zed that referenced this pull request Feb 23, 2025
shenjackyuanjie added a commit to shenjackyuanjie/zed that referenced this pull request Feb 24, 2025
shenjackyuanjie added a commit to shenjackyuanjie/zed that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement run-bundling Configures PR to run the bundle step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the OS-level CA certificate bundle(s) for network calls
5 participants