Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish zed to nixos package registry #4252

Closed
brizzbuzz opened this issue Jan 24, 2024 · 14 comments
Closed

publish zed to nixos package registry #4252

brizzbuzz opened this issue Jan 24, 2024 · 14 comments
Labels
feature [core label]

Comments

@brizzbuzz
Copy link

Hey :) so excited this is open-sourced now.

Would love for this to be published to the nix package registry for easy installs to NixOS

@srid
Copy link

srid commented Jan 24, 2024

Adding a flake.nix to this repo would also be an useful thing to do because, in addition to being able to nix run it off this repo (without relying on nixpkgs), you can also use Nix to develop on the project.

The flake can also be used as reference for upstreaming to nixpkgs at this point, making that a simpler process.

EDIT: For those curious to see what this would look like, here's a template: https://github.com/srid/rust-nix-template ... for anything advanced, there's also crane (eg.: this Dioxus app uses it).

EDIT 2: The foreman/Procfile stuff can be ported to https://github.com/Platonic-Systems/process-compose-flake

@Reverier-Xu
Copy link

*zed currently only supports macOS, and getting it to support Linux may take a while of work.

@ghost
Copy link

ghost commented Jan 24, 2024

*zed currently only supports macOS, and getting it to support Linux may take a while of work.

Nix is available on macOS. :)

@toplinuxsir
Copy link

Support linux is a great idea

@liberodark
Copy link

I hope a package for NixOS

@domenkozar
Copy link

NixOS/nixpkgs#284010

@musjj
Copy link

musjj commented Apr 22, 2024

Already merged now. But an upstream flake.nix would still be nice to have to make it easier for Nix users to contribute.

@boomshroom
Copy link

Complication: Zed downloads its own prebuilt binary of NodeJS (currently 18.15.0; closest version in nixpkgs is 18.20.2). While less of an issue for MacOS or other Linux distros that have Nix added on, NixOS itself wouldn't be able to run the packaged version of node without nix-ld.

@PedroHLC
Copy link

PedroHLC commented May 17, 2024

Complication: Zed downloads its own prebuilt binary of NodeJS (currently 18.15.0

We could substituteInPlace the occurrences of zed::node_binary_path(), that would help a lot. (but then we have to install the extensions as dev)

But Zed could use having more configurable paths (Settings and/or EnvVars) because for example, the elm-language-server support is very tied to using it through their nodejs, meanwhile we could use it from drop-in executable.

@libewa
Copy link

libewa commented May 26, 2024

but then we have to install the extensions as dev

This could be partially fixed (or worked around) by publishing the extensions to nixpkgs using a zedExtensions namespace (i.e. publishing the extensions as zedExtensions.something, like vscode does with vscodeExtensions) and installing them through home-manager. I am currently working on a home-manager module for Zed, so installing extensions with nix would also be one of my bucket list items.

@libewa
Copy link

libewa commented May 27, 2024

I got this working using auto_install_extensions, the module is now waiting for approval in nix-community/home-manager#5455.

@sokai
Copy link

sokai commented Jul 11, 2024

JFYI: https://zed.dev/blog/zed-on-linux
.oO(Maybe it can help here?)
KR

@IvanTurgenev
Copy link

Looks like it is already there

@PedroHLC
Copy link

PedroHLC commented Aug 2, 2024

yeah, this can be closed, Nixpkgs has the latest tag that can be built with rust 1.79 (and pretty sure as soon as 1.80 is in-repo we'll bump it again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [core label]
Projects
None yet
Development

No branches or pull requests