-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce {Fixed,Advice,Instance}Query
for Expression::{Fixed,Advice,Instance}
#616
Conversation
1438ac5
to
6987b2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. This is all so much cleaner now, I love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6987b2e. I checked that this revision still passes orchard
tests, including the serialized proof test case (ensuring that the Orchard circuit is unaltered by this change).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. #633 should be rebased on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK
This PR aims to make
Expression::{Fixed,Advice,Instance}
wrap their own*Query
structure, to make it possible to add private fields in each variant (e.g. #593 needs to add a private fieldphase
).For backwards compatibility (to make vk to hash to same value), it implements
fmt::Debug
forExpression
manually.Also to make module
dev
less difference, it also introduces non-public structureAnyQuery
to reuse existing helper functions.