cost-model.rs: Correct lookup required degree calculation. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
approved these changes
Apr 18, 2022
| @@ -125,7 +125,7 @@ impl FromStr for Lookup { | |||
|
|
|||
| impl Lookup { | |||
| fn required_degree(&self) -> usize { | |||
| 1 + cmp::max(1, self.input_deg) + cmp::max(1, self.table_deg) | |||
| 2 + cmp::max(1, self.input_deg) + cmp::max(1, self.table_deg) | |||
There was a problem hiding this comment.
I confirmed that the reason for this bug was that this cost model example was implemented before the lookup argument was made perfectly zero-knowledge: 1f1b705
I also agree that this happens to ensure the lowest returned degree is 4, matching the real code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539