Fix mock prover performance regression for lookup arguments #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
mockprover-regression
branch
2 times, most recently
from
67611fd to
fdd9362
Compare
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 70.49% 70.58% +0.09%
==========================================
Files 42 42
Lines 5297 5321 +24
==========================================
+ Hits 3734 3756 +22
- Misses 1563 1565 +2
Continue to review full report at Codecov.
|
|
I recommend to review ignoring whitespace changes. |
daira
commented
Dec 28, 2021
ebfull
previously requested changes
Dec 28, 2021
|
This will conflict with #433; I'd prefer to merge that PR before this one, in part because it will simplify the diff here. |
therealyingtong
approved these changes
Jan 4, 2022
|
Changing this back to draft because I need to change it to optimize fill rows rather than zero rows (as well as resolving conflicts). |
daira
force-pushed
the
mockprover-regression
branch
from
968b6e0 to
9b8ecc7
Compare
are contained in the table, fixing a performance regression. This includes an optimization for "fill rows", which are assumed in this commit to be all-zeros. closes zcash#398 Signed-off-by: Daira Hopwood <daira@jacaranda.org>
daira
force-pushed
the
mockprover-regression
branch
from
9b8ecc7 to
7107b83
Compare
… row. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
r3ld3v
modified the milestones:
Core Sprint 2022-04,
Core Sprint 2022-06,
Core Sprint 2022-08
|
This is still up-to-date and needs review. (@therealyingtong's utACK was before it changed substantially.) |
str4d
approved these changes
Apr 18, 2022
daira
commented
Apr 19, 2022
str4d
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #398
Signed-off-by: Daira Hopwood daira@jacaranda.org