Add a Constraints helper
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 70.19% 70.09% -0.11%
==========================================
Files 42 42
Lines 5208 5216 +8
==========================================
Hits 3656 3656
- Misses 1552 1560 +8
Continue to review full report at Codecov.
|
str4d
force-pushed
the
constraints-helper
branch
from
34912cf to
b73429a
Compare
str4d
force-pushed
the
constraints-helper
branch
2 times, most recently
from
a058ffd to
12d729a
Compare
str4d
force-pushed
the
constraints-helper
branch
from
12d729a to
634e1ec
Compare
str4d
added
A-dev-tooling
str4d
force-pushed
the
constraints-helper
branch
from
634e1ec to
82a5b61
Compare
str4d
force-pushed
the
constraints-helper
branch
from
82a5b61 to
a12935b
Compare
|
Rebased to fix a doctest that wasn't updated for the workspace refactor, and add a changelog entry. |
There are two existing patterns for constructing a gate from a set of
constraints with a common selector:
- Create an iterator of constraints, where each constraint includes the
selector:
```
vec![
("foo", selector.clone() * foo),
("bar", selector.clone() * bar),
("baz", selector * bar),
]
```
This requires the user to write O(n) `selector.clone()` calls.
- Create an iterator of constraints, and then map the selector in:
```
vec![
("foo", foo),
("bar", bar),
("baz", bar),
].into_iter().map(move |(name, poly)| (name, selector.clone() * poly))
```
This looks cleaner overall, but the API is not as intuitive, and it
is messier when the constraints are named.
The `Constraints` struct provides a third, clearer API:
```
Constraints::with_selector(
selector,
vec![
("foo", foo),
("bar", bar),
("baz", bar),
],
)
```
This focuses on the structure of the constraints, and handles the
selector application for the user.
str4d
force-pushed
the
constraints-helper
branch
from
a12935b to
d93846f
Compare
|
Rebased to fix a merge conflict in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two existing patterns for constructing a gate from a set of
constraints with a common selector:
Create an iterator of constraints, where each constraint includes the
selector:
This requires the user to write O(n)
selector.clone()calls.Create an iterator of constraints, and then map the selector in:
This looks cleaner overall, but the API is not as intuitive, and it
is messier when the constraints are named.
The
Constraintsstruct provides a third, clearer API:This focuses on the structure of the constraints, and handles the
selector application for the user.