Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost model miscalculates the degree of lookup arguments #539

Closed
daira opened this issue Apr 5, 2022 · 0 comments · Fixed by #549
Closed

Cost model miscalculates the degree of lookup arguments #539

daira opened this issue Apr 5, 2022 · 0 comments · Fixed by #549
Assignees
Labels
A-lookup Area: Lookup tables C-bug Category: This is a bug S-committed
Milestone

Comments

@daira
Copy link
Contributor

daira commented Apr 5, 2022

fn required_degree(&self) -> usize {
1 + cmp::max(1, self.input_deg) + cmp::max(1, self.table_deg)
}

does not match

std::cmp::max(
// (1 - (l_last + l_blind)) z(\omega X) (a'(X) + \beta) (s'(X) + \gamma)
4,
// (1 - (l_last + l_blind)) z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma)
2 + input_degree + table_degree,
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lookup Area: Lookup tables C-bug Category: This is a bug S-committed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants