Skip to content

Commit 31be102

Browse files
committed
perf: optimize min-match-percentage default (#107)
1 parent fa369b2 commit 31be102

File tree

5 files changed

+21
-24
lines changed

5 files changed

+21
-24
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ optional arguments:
148148
--read-layout-min-match-percentage FLOAT
149149
minimum percentage of reads that contain a given
150150
adapter sequence in order for it to be considered
151-
as the library's 3'-end adapter (default: 2)
151+
as the library's 3'-end adapter (default: 0.1)
152152
--read-layout-min-frequency-ratio FLOAT
153153
minimum frequency ratio between the first and second
154154
most frequent adapter in order for the former to be

data/adapter_fragments.txt

+17-20
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,17 @@
1-
AATGATACGGCGACC
2-
ACACTCTTTCCCTAC
3-
ATCTCGTATGCCGTC
4-
CAAGCAGAAGACGGC
5-
CCGAGCCCACGAGAC
6-
CCGGTTCTTCCCTGC
7-
CGACAGGTTCAGAGT
8-
CGGTCTCGGCATTCC
9-
CTGTAGGCACCATCA
10-
GATCGGAAGAGCGGT
11-
GATCGGAAGAGCTCG
12-
GATCGTCGGACTGTA
13-
GCCTTGGCACCCGAG
14-
GTCTCGTGGGCTCGG
15-
GTGACTGGAGTTCAG
16-
TCGGACTGTAGAACT
17-
TCGTCGGCAGCGTCA
18-
TGGAATTCTCGGGTG
19-
AGATCGGAAGAGCGT
20-
AGATCGGAAGAGCAC
1+
AATGATACGGCG
2+
ACACTCTTTCCC
3+
ATCTCGTATGCC
4+
CAAGCAGAAGAC
5+
CCGAGCCCACGA
6+
CCGGTTCTTCCC
7+
CGACAGGTTCAG
8+
CGGTCTCGGCAT
9+
CTGTAGGCACCA
10+
GATCGTCGGACT
11+
GCCTTGGCACCC
12+
GTCTCGTGGGCT
13+
GTGACTGGAGTT
14+
TCGGACTGTAGA
15+
TCGTCGGCAGCG
16+
TGGAATTCTCGG
17+
AGATCGGAAGAG

htsinfer/cli.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def __call__(
170170
dest="read_layout_min_match_pct",
171171
metavar="FLOAT",
172172
type=float,
173-
default=2,
173+
default=0.1,
174174
help=(
175175
"minimum percentage of reads that contain a given adapter "
176176
"sequence in order for it to be considered as the library's "

htsinfer/get_read_layout.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def __init__(
182182
path: Path,
183183
adapter_file: Path,
184184
out_dir: Path = Path.cwd(),
185-
min_match_pct: float = 2,
185+
min_match_pct: float = 0.1,
186186
min_freq_ratio: float = 2,
187187
):
188188
"""Class constructor."""

htsinfer/models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ class Args(BaseModel):
413413
threads: int = 1
414414
transcripts_file: Path = Path()
415415
read_layout_adapter_file: Path = Path()
416-
read_layout_min_match_pct: float = 2
416+
read_layout_min_match_pct: float = 0.1
417417
read_layout_min_freq_ratio: float = 2
418418
lib_source_min_match_pct: float = 2
419419
lib_source_min_freq_ratio: float = 2

0 commit comments

Comments
 (0)