[WIP] Upgrade Java to version 17 #1377
Conversation
KeshavRathi
requested review from
whiskeysierra,
lukasniemeier-zalando and
fatroom
as code owners
KeshavRathi
changed the title
|
@KeshavRathi thank you for contribution: you need to change JDK version for GH actions to adjust CI builds: https://github.com/zalando/riptide/blob/main/.github/workflows/build.yaml |
Should it be 1.7 or 17.0 in the build.yaml? |
According to https://github.com/actions/setup-java it's enough to specify |
| @@ -1 +1 @@ | |||
| 1.8 | |||
| 17.0 | |||
There was a problem hiding this comment.
please verify your IDE settings, to add new lines at the end of the files
| @@ -97,6 +101,16 @@ | |||
| <groupId>org.zalando</groupId> | |||
| <artifactId>riptide-httpclient</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>jakarta.xml.soap</groupId> | |||
| <artifactId>jakarta.xml.soap-api</artifactId> | |||
There was a problem hiding this comment.
jakarta.xml.ws-api should be enough here instead of soap and bind separate artefacts
There was a problem hiding this comment.
There are compilation errors if I don't include them
There was a problem hiding this comment.
hm, just verified - it's because spring 5 still depends on Jakarta 2.3.3 (packages javax.xml). So I'm not sure how new changes to Jakarta namespaces will work with spring 5.
Can you try to move to jdk17 but still use javax.xml for web services as first step?
There was a problem hiding this comment.
Sure. Will try that tomorrow. Thanks
|
Closed in favour #1395 |
Java needs to upgraded to 1.17 for Spring 6
Description
Spring 6 requires Java version greater than 17
Motivation and Context
My project uses riptide and we want to upgrade the Spring version and cannot do that because riptide is currently at previous version of Spring
Types of changes
Checklist: